Enable method signature style ESLint rule (#3849)

* Remove redundant rules handled by prettier

* Turn on method-signature-style

* Auto-lint files according to method-signature-style rule

* Add changeset

.changeset/hip-owls-knock.md

@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+Enable method signature style ESLint rule

.eslintrc.json

@@ -64,9 +64,6 @@
     // These rules should be reviewed - tracked in
     // Tracked in https://github.com/saleor/saleor-dashboard/issues/3813
     "@typescript-eslint/consistent-type-imports": "off",
-    "@typescript-eslint/indent": "off",
-    "@typescript-eslint/member-delimiter-style": "off",
-    "@typescript-eslint/method-signature-style": "off",
     "@typescript-eslint/no-confusing-void-expression": "off",
     "@typescript-eslint/no-unnecessary-type-assertion": "off",
     "@typescript-eslint/prefer-reduce-type-parameter": "off",

src/apps/components/AppFrame/AppFrame.tsx

@@ -22,7 +22,7 @@ interface Props {
   refetch?: () => void;
   dashboardVersion: string;
   coreVersion?: string;
-  onError?(): void;
+  onError?: () => void;
 }
 
 const getOrigin = (url: string) => new URL(url).origin;

src/apps/components/AppPermissionsDialog/AppPermissionsDialogConfirmation.tsx

@@ -10,8 +10,8 @@ const messages = AppPermissionsDialogMessages.confirmation;
 interface Props {
   removedPermissions: PermissionEnum[];
   addedPermissions: PermissionEnum[];
-  onBack(): void;
+  onBack: () => void;
-  onApprove(): void;
+  onApprove: () => void;
 }
 
 export const AppPermissionsDialogConfirmation = ({

src/apps/components/AppPermissionsDialog/AppPermissionsDialogPermissionPicker.tsx

@@ -10,9 +10,9 @@ const messages = AppPermissionsDialogMessages.permissionsPicker;
 interface AppPermissionsDialogPermissionPickerProps {
   allPermissions: AppPermission[];
   selected: PermissionEnum[];
-  onSubmit(): void;
+  onSubmit: () => void;
-  onChange(codes: PermissionEnum[]): void;
+  onChange: (codes: PermissionEnum[]) => void;
-  onClose(): void;
+  onClose: () => void;
 }
 
 /**

src/apps/components/InstallWithManifestFormButton/InstallWithManifestFormButton.tsx

@@ -9,7 +9,7 @@ import { messages } from "./messages";
 import { useStyles } from "./styles";
 
 interface InstallWithManifestFormButtonProps {
-  onSubmitted(manifestUrl: string): void;
+  onSubmitted: (manifestUrl: string) => void;
 }
 
 export const InstallWithManifestFormButton: React.FC<

src/apps/hooks/useExtensions.ts

@@ -21,11 +21,11 @@ export interface Extension {
   label: string;
   mount: AppExtensionMountEnum;
   url: string;
-  open(): void;
+  open: () => void;
 }
 
 export interface ExtensionWithParams extends Omit<Extension, "open"> {
-  open(params: AppDetailsUrlMountQueryParams): void;
+  open: (params: AppDetailsUrlMountQueryParams) => void;
 }
 
 export const extensionMountPoints = {

src/categories/components/CategoryCreatePage/CategoryCreatePage.tsx

@@ -20,7 +20,7 @@ export interface CategoryCreatePageProps {
   disabled: boolean;
   saveButtonBarState: ConfirmButtonTransitionState;
   backUrl: string;
-  onSubmit(data: CategoryCreateData);
+  onSubmit: (data: CategoryCreateData) => any;
 }
 
 export const CategoryCreatePage: React.FC<CategoryCreatePageProps> = ({

src/categories/components/CategoryDeleteDialog/CategoryDeleteDialog.tsx

@@ -31,8 +31,8 @@ const useStyles = makeStyles(
 export interface CategoryDeleteDialogProps {
   open: boolean;
   name: string;
-  onClose();
+  onClose: () => any;
-  onConfirm();
+  onConfirm: () => any;
 }
 
 const CategoryDeleteDialog: React.FC<CategoryDeleteDialogProps> = props => {

src/categories/components/CategoryUpdatePage/CategoryUpdatePage.tsx

@@ -45,8 +45,8 @@ export interface CategoryUpdatePageProps {
   onProductsDelete: () => void;
   onSelectProductsIds: (ids: number[], clearSelection: () => void) => void;
   onSelectCategoriesIds: (ids: number[], clearSelection: () => void) => void;
-  onImageUpload(file: File);
+  onImageUpload: (file: File) => any;
-  onDelete();
+  onDelete: () => any;
 }
 
 const CategoriesTab = Tab(CategoryPageTab.categories);

src/components/ActionDialog/ActionDialog.tsx

@@ -16,7 +16,7 @@ export interface ActionDialogProps extends DialogProps {
   title: string;
   variant?: ActionDialogVariant;
   backButtonText?: string;
-  onConfirm();
+  onConfirm: () => any;
 }
 
 const ActionDialog: React.FC<ActionDialogProps> = props => {

src/components/ActionDialog/DialogButtons.tsx

@@ -18,7 +18,7 @@ interface DialogButtonsProps {
   children?: React.ReactNode;
   showBackButton?: boolean;
   backButtonText?: string;
-  onConfirm();
+  onConfirm: () => any;
 }
 
 const DialogButtons: React.FC<DialogButtonsProps> = props => {

src/components/AddressEdit/AddressEdit.tsx

@@ -32,8 +32,8 @@ interface AddressEditProps {
   data: AddressTypeInput;
   disabled?: boolean;
   errors: Array<AccountErrorFragment | OrderErrorFragment>;
-  onChange(event: React.ChangeEvent<any>);
+  onChange: (event: React.ChangeEvent<any>) => any;
-  onCountryChange(event: React.ChangeEvent<any>);
+  onCountryChange: (event: React.ChangeEvent<any>) => any;
 }
 
 const PossibleFormFields = {

src/components/ButtonWithSelect/ButtonWithSelect.tsx

@@ -18,7 +18,7 @@ import { useStyles } from "./styles";
 interface Option {
   label: string;
   disabled?: boolean;
-  onSelect(e: React.MouseEvent<HTMLLIElement, MouseEvent>): void;
+  onSelect: (e: React.MouseEvent<HTMLLIElement, MouseEvent>) => void;
 }
 
 export interface ButtonWithSelectProps

src/components/ControlledCheckbox.tsx

@@ -11,7 +11,7 @@ export interface ControlledCheckboxProps {
   disabled?: boolean;
   checkedIcon?: React.ReactNode;
   testId?: string;
-  onChange(event: any);
+  onChange: (event: any) => any;
 }
 
 export const ControlledCheckbox: React.FC<ControlledCheckboxProps> = ({

src/components/ControlledSwitch.tsx

@@ -20,7 +20,7 @@ interface ControlledSwitchProps {
   name: string;
   secondLabel?: string | React.ReactNode;
   uncheckedLabel?: string | React.ReactNode;
-  onChange?(event: React.ChangeEvent<any>);
+  onChange?: (event: React.ChangeEvent<any>) => any;
 }
 
 export const ControlledSwitch: React.FC<ControlledSwitchProps> = props => {

src/components/EditableTableCell/EditableTableCell.tsx

@@ -50,7 +50,7 @@ interface EditableTableCellProps {
   focused?: boolean;
   InputProps?: TextFieldProps;
   value: string;
-  onConfirm(value: string): any;
+  onConfirm: (value: string) => any;
 }
 
 export const EditableTableCell: React.FC<EditableTableCellProps> = props => {

src/components/FilterCard/FilterCard.tsx

@@ -6,7 +6,7 @@ import React from "react";
 import { useIntl } from "react-intl";
 
 export interface FilterCardProps {
-  handleClear();
+  handleClear: () => any;
 }
 
 const FilterCard: React.FC<FilterCardProps> = ({ children, handleClear }) => {

src/components/MultiSelectField/MultiSelectField.tsx

@@ -44,7 +44,7 @@ interface MultiSelectFieldProps {
   name?: string;
   selectProps?: SelectProps;
   value?: string[];
-  onChange(event: any);
+  onChange: (event: any) => any;
 }
 
 export const MultiSelectField: React.FC<MultiSelectFieldProps> = props => {

src/components/PhoneField/PhoneField.tsx

@@ -21,7 +21,7 @@ interface PhoneFieldProps {
   number: string;
   prefixes: string[];
   label?: string;
-  onChange(event: React.ChangeEvent<any>);
+  onChange: (event: React.ChangeEvent<any>) => any;
 }
 
 const PhoneField: React.FC<PhoneFieldProps> = props => {

src/components/PriceField/PriceField.tsx

@@ -43,7 +43,7 @@ export interface PriceFieldProps {
   inputProps?: InputProps["inputProps"];
   InputLabelProps?: InputLabelProps;
   required?: boolean;
-  onChange(event: any);
+  onChange: (event: any) => any;
 }
 
 export const PriceField: React.FC<PriceFieldProps> = props => {

src/components/RowNumberSelect/RowNumberSelect.tsx

@@ -34,7 +34,7 @@ interface RowNumberSelectProps {
   choices: number[];
   className?: string;
   rowNumber: number;
-  onChange(value: number);
+  onChange: (value: number) => any;
 }
 
 const RowNumberSelect: React.FC<RowNumberSelectProps> = ({

src/components/SeoForm/SeoForm.tsx

@@ -54,8 +54,8 @@ interface SeoFormProps {
   slug: string;
   slugPlaceholder?: string;
   titlePlaceholder: string;
-  onChange(event: any);
+  onChange: (event: any) => any;
-  onClick?();
+  onClick?: () => any;
 }
 
 export const SeoForm: React.FC<SeoFormProps> = props => {

src/components/SingleSelectField/SingleSelectField.tsx

@@ -60,7 +60,7 @@ interface SingleSelectFieldProps {
   placeholder?: string;
   value?: string;
   InputProps?: OutlinedInputProps;
-  onChange(event: any);
+  onChange: (event: any) => any;
 }
 
 export const SingleSelectField: React.FC<SingleSelectFieldProps> = props => {

src/components/TablePagination/TablePaginationActions.tsx

@@ -58,8 +58,8 @@ export interface TablePaginationActionsProps {
   hasNextPage: boolean;
   hasPreviousPage: boolean;
   nextIconButtonProps?: any;
-  onNextPage(event);
+  onNextPage: (event) => any;
-  onPreviousPage(event);
+  onPreviousPage: (event) => any;
 }
 
 export const TablePaginationActions: React.FC<

src/components/Timeline/Timeline.tsx

@@ -67,8 +67,8 @@ interface TimelineAddNoteProps {
   disabled?: boolean;
   message: string;
   reset: () => void;
-  onChange(event: React.ChangeEvent<any>);
+  onChange: (event: React.ChangeEvent<any>) => any;
-  onSubmit(event: React.FormEvent<any>);
+  onSubmit: (event: React.FormEvent<any>) => any;
 }
 
 export const Timeline: React.FC<TimelineProps> = props => {

src/customers/components/CustomerCreateAddress/CustomerCreateAddress.tsx

@@ -26,8 +26,8 @@ export interface CustomerCreateAddressProps {
   data: AddressTypeInput;
   disabled: boolean;
   errors: AccountErrorFragment[];
-  onChange(event: React.ChangeEvent<any>);
+  onChange: (event: React.ChangeEvent<any>) => any;
-  onCountryChange(event: React.ChangeEvent<any>);
+  onCountryChange: (event: React.ChangeEvent<any>) => any;
 }
 
 const CustomerCreateAddress: React.FC<CustomerCreateAddressProps> = props => {

src/featureFlags/Strategy.ts

@@ -1,9 +1,9 @@
 import { FlagList } from "./availableFlags";
 
 export interface Strategy {
-  fetchAll(): Promise<FlagList>;
+  fetchAll: () => Promise<FlagList>;
 }
 
 export interface PersistableStrategy extends Strategy {
-  store?(flags: FlagList): Promise<void>;
+  store?: (flags: FlagList) => Promise<void>;
 }

src/orders/components/OrderChangeWarehouseDialog/OrderChangeWarehouseDialog.tsx

@@ -44,7 +44,7 @@ export interface OrderChangeWarehouseDialogProps {
   line: OrderFulfillLineFragment;
   currentWarehouseId: string;
   onConfirm: (warehouse: WarehouseFragment) => void;
-  onClose();
+  onClose: () => any;
 }
 
 export const OrderChangeWarehouseDialog: React.FC<

src/orders/components/OrderCustomerAddressesEditDialog/OrderCustomerAddressesEditDialog.tsx

@@ -64,10 +64,10 @@ export interface OrderCustomerAddressesEditDialogProps {
   customerAddresses?: AddressFragment[];
   defaultShippingAddress?: Node;
   defaultBillingAddress?: Node;
-  onClose();
+  onClose: () => any;
-  onConfirm(
+  onConfirm: (
     data: Partial<OrderCustomerAddressesEditDialogOutput>,
-  ): SubmitPromise<any[]>;
+  ) => SubmitPromise<any[]>;
 }
 
 const defaultSearchState: OrderCustomerSearchAddressState = {

src/orders/components/OrderCustomerAddressesEditDialog/OrderCustomerAddressesSearch.tsx

@@ -35,7 +35,7 @@ export interface OrderCustomerAddressesSearchProps {
   customerAddresses: AddressFragment[];
   onChangeCustomerShippingAddress: (customerAddress: AddressFragment) => void;
   onChangeCustomerBillingAddress: (customerAddress: AddressFragment) => void;
-  exitSearch();
+  exitSearch: () => any;
 }
 
 const OrderCustomerAddressesSearch: React.FC<

src/orders/components/OrderCustomerChangeDialog/OrderCustomerChangeDialog.tsx

@@ -25,7 +25,7 @@ import { useStyles } from "./styles";
 export interface OrderCustomerChangeDialogProps {
   open: boolean;
   onConfirm: (data: OrderCustomerChangeData) => void;
-  onClose();
+  onClose: () => any;
 }
 
 const OrderCustomerChangeDialog: React.FC<

src/orders/components/OrderDetailsPage/OrderDetailsPage.tsx

@@ -64,27 +64,27 @@ export interface OrderDetailsPageProps {
   ) => void;
   onOrderLineRemove?: (id: string) => void;
   onShippingMethodEdit?: () => void;
-  onBillingAddressEdit();
+  onBillingAddressEdit: () => any;
-  onFulfillmentApprove(id: string);
+  onFulfillmentApprove: (id: string) => any;
-  onFulfillmentCancel(id: string);
+  onFulfillmentCancel: (id: string) => any;
-  onFulfillmentTrackingNumberUpdate(id: string);
+  onFulfillmentTrackingNumberUpdate: (id: string) => any;
-  onOrderFulfill();
+  onOrderFulfill: () => any;
-  onProductClick?(id: string);
+  onProductClick?: (id: string) => any;
-  onPaymentCapture();
+  onPaymentCapture: () => any;
-  onMarkAsPaid();
+  onMarkAsPaid: () => any;
-  onPaymentRefund();
+  onPaymentRefund: () => any;
-  onPaymentVoid();
+  onPaymentVoid: () => any;
-  onShippingAddressEdit();
+  onShippingAddressEdit: () => any;
-  onOrderCancel();
+  onOrderCancel: () => any;
-  onNoteAdd(data: HistoryFormData);
+  onNoteAdd: (data: HistoryFormData) => any;
-  onProfileView();
+  onProfileView: () => any;
-  onOrderReturn();
+  onOrderReturn: () => any;
-  onInvoiceClick(invoiceId: string);
+  onInvoiceClick: (invoiceId: string) => any;
-  onInvoiceGenerate();
+  onInvoiceGenerate: () => any;
-  onInvoiceSend(invoiceId: string);
+  onInvoiceSend: (invoiceId: string) => any;
-  onTransactionAction(transactionId: string, actionType: TransactionActionEnum);
+  onTransactionAction: (transactionId: string, actionType: TransactionActionEnum) => any;
-  onAddManualTransaction();
+  onAddManualTransaction: () => any;
-  onSubmit(data: MetadataIdSchema): SubmitPromise;
+  onSubmit: (data: MetadataIdSchema) => SubmitPromise;
 }
 
 const OrderDetailsPage: React.FC<OrderDetailsPageProps> = props => {

src/orders/components/OrderFulfillStockExceededDialog/OrderFulfillStockExceededDialog.tsx

@@ -27,8 +27,8 @@ export interface OrderFulfillStockExceededDialogProps {
   open: boolean;
   formsetData: OrderFulfillStockFormsetData;
   confirmButtonState: ConfirmButtonTransitionState;
-  onSubmit();
+  onSubmit: () => any;
-  onClose();
+  onClose: () => any;
 }
 
 const OrderFulfillStockExceededDialog: React.FC<

src/orders/components/OrderFulfilledProductsCard/ActionButtons.tsx

@@ -17,8 +17,8 @@ interface AcionButtonsProps {
   orderIsPaid?: boolean;
   fulfillmentAllowUnpaid: boolean;
   hasTransactions: boolean;
-  onTrackingCodeAdd();
+  onTrackingCodeAdd: () => any;
-  onApprove();
+  onApprove: () => any;
 }
 
 const statusesToShow = [

src/orders/components/OrderFulfillmentApproveDialog/OrderFulfillmentApproveDialog.tsx

@@ -29,8 +29,8 @@ export interface OrderFulfillmentAcceptDialogProps {
   confirmButtonState: ConfirmButtonTransitionState;
   errors: OrderErrorFragment[];
   open: boolean;
-  onClose(): void;
+  onClose: () => void;
-  onConfirm(data: OrderFulfillmentAcceptDialogFormData): void;
+  onConfirm: (data: OrderFulfillmentAcceptDialogFormData) => void;
 }
 
 const OrderFulfillmentAcceptDialog: React.FC<

src/orders/components/OrderFulfillmentCancelDialog/OrderFulfillmentCancelDialog.tsx

@@ -46,8 +46,8 @@ export interface OrderFulfillmentCancelDialogProps {
   errors: OrderErrorFragment[];
   open: boolean;
   warehouses: WarehouseFragment[];
-  onClose();
+  onClose: () => any;
-  onConfirm(data: OrderFulfillmentCancelDialogFormData);
+  onConfirm: (data: OrderFulfillmentCancelDialogFormData) => any;
 }
 
 const OrderFulfillmentCancelDialog: React.FC<

src/orders/components/OrderFulfillmentTrackingDialog/OrderFulfillmentTrackingDialog.tsx

@@ -31,8 +31,8 @@ export interface OrderFulfillmentTrackingDialogProps {
   errors: OrderErrorFragment[];
   open: boolean;
   trackingNumber: string;
-  onClose();
+  onClose: () => any;
-  onConfirm(data: FormData);
+  onConfirm: (data: FormData) => any;
 }
 
 const OrderFulfillmentTrackingDialog: React.FC<

src/orders/components/OrderPaymentOrTransaction/OrderPaymentOrTransaction.tsx

@@ -14,12 +14,12 @@ import { OrderTransactionsWrapper } from "./OrderTransactionsWrapper";
 export interface OrderPaymentOrTransactionProps {
   order: OrderDetailsFragment;
   shop: OrderDetailsQuery["shop"];
-  onTransactionAction(transactionId: string, actionType: TransactionActionEnum);
+  onTransactionAction: (transactionId: string, actionType: TransactionActionEnum) => any;
-  onPaymentCapture();
+  onPaymentCapture: () => any;
-  onPaymentVoid();
+  onPaymentVoid: () => any;
-  onPaymentRefund();
+  onPaymentRefund: () => any;
-  onMarkAsPaid();
+  onMarkAsPaid: () => any;
-  onAddManualTransaction();
+  onAddManualTransaction: () => any;
 }
 
 export const OrderPaymentOrTransaction: React.FC<

src/orders/components/OrderPaymentOrTransaction/OrderTransactionsWrapper.tsx

@@ -20,11 +20,11 @@ import { getFilteredPayments } from "./utils";
 interface OrderTransactionsWrapper {
   order: OrderDetailsFragment;
   shop: OrderDetailsQuery["shop"];
-  onTransactionAction(transactionId: string, actionType: TransactionActionEnum);
+  onTransactionAction: (transactionId: string, actionType: TransactionActionEnum) => any;
-  onPaymentCapture();
+  onPaymentCapture: () => any;
-  onMarkAsPaid();
+  onMarkAsPaid: () => any;
-  onPaymentVoid();
+  onPaymentVoid: () => any;
-  onAddManualTransaction();
+  onAddManualTransaction: () => any;
 }
 
 export const OrderTransactionsWrapper: React.FC<OrderTransactionsWrapper> = ({

src/orders/components/OrderPaymentVoidDialog/OrderPaymentVoidDialog.tsx

@@ -22,8 +22,8 @@ export interface OrderPaymentVoidDialogProps {
   confirmButtonState: ConfirmButtonTransitionState;
   errors: OrderErrorFragment[];
   open: boolean;
-  onClose?();
+  onClose?: () => any;
-  onConfirm?();
+  onConfirm?: () => any;
 }
 
 const OrderPaymentVoidDialog: React.FC<OrderPaymentVoidDialogProps> = ({

src/orders/components/OrderReturnPage/OrderReturnRefundItemsCard/ReturnItemsCard.tsx

@@ -103,7 +103,7 @@ interface OrderReturnRefundLinesCardProps {
   itemsSelections: FormsetReplacementData;
   itemsQuantities: FormsetQuantityData;
   onChangeSelected: FormsetChange<boolean>;
-  onSetMaxQuantity();
+  onSetMaxQuantity: () => any;
 }
 
 const ItemsCard: React.FC<OrderReturnRefundLinesCardProps> = ({

src/orders/components/OrderReturnPage/components/ItemsCard/ItemsCard.tsx

@@ -44,7 +44,7 @@ interface OrderReturnRefundLinesCardProps {
   itemsSelections: FormsetReplacementData;
   itemsQuantities: FormsetQuantityData;
   onChangeSelected: FormsetChange<boolean>;
-  onSetMaxQuantity();
+  onSetMaxQuantity: () => any;
 }
 
 export const ItemsCard: React.FC<OrderReturnRefundLinesCardProps> = ({

src/orders/components/OrderShippingMethodEditDialog/OrderShippingMethodEditDialog.tsx

@@ -66,8 +66,8 @@ export interface OrderShippingMethodEditDialogProps {
   open: boolean;
   shippingMethod: string;
   shippingMethods?: OrderDetailsFragment["shippingMethods"];
-  onClose();
+  onClose: () => any;
-  onSubmit?(data: FormData);
+  onSubmit?: (data: FormData) => any;
 }
 
 const OrderShippingMethodEditDialog: React.FC<

src/products/components/ProductCreatePage/ProductCreatePage.tsx

@@ -95,7 +95,7 @@ interface ProductCreatePageProps {
   onAttributeSelectBlur: () => void;
   onCloseDialog: (currentParams?: ProductCreateUrlQueryParams) => void;
   onSelectProductType: (productTypeId: string) => void;
-  onSubmit?(data: ProductCreateData);
+  onSubmit?: (data: ProductCreateData) => any;
 }
 
 export const ProductCreatePage: React.FC<ProductCreatePageProps> = ({

src/products/components/ProductDetailsForm/ProductDetailsForm.tsx

@@ -20,7 +20,7 @@ interface ProductDetailsFormProps {
   disabled?: boolean;
   errors: ProductErrorFragment[];
 
-  onChange(event: any);
+  onChange: (event: any) => any;
 }
 
 export const ProductDetailsForm: React.FC<ProductDetailsFormProps> = ({

src/products/components/ProductMedia/ProductMedia.tsx

@@ -71,8 +71,8 @@ interface ProductMediaProps {
   getImageEditUrl: (id: string) => string;
   onImageDelete: (id: string) => () => void;
   onImageReorder?: ReorderAction;
-  onImageUpload(file: File);
+  onImageUpload: (file: File) => any;
-  openMediaUrlModal();
+  openMediaUrlModal: () => any;
 }
 
 const ProductMedia: React.FC<ProductMediaProps> = props => {

src/products/components/ProductUpdatePage/ProductUpdatePage.tsx

@@ -113,11 +113,11 @@ export interface ProductUpdatePageProps {
   onSubmit: (data: ProductUpdateSubmitData) => SubmitPromise;
   onVariantShow: (id: string) => void;
   onAttributeSelectBlur: () => void;
-  onDelete();
+  onDelete: () => any;
-  onImageReorder?(event: { oldIndex: number; newIndex: number });
+  onImageReorder?: (event: { oldIndex: number; newIndex: number }) => any;
-  onImageUpload(file: File);
+  onImageUpload: (file: File) => any;
-  onMediaUrlUpload(mediaUrl: string);
+  onMediaUrlUpload: (mediaUrl: string) => any;
-  onSeoClick?();
+  onSeoClick?: () => any;
 }
 
 export const ProductUpdatePage: React.FC<ProductUpdatePageProps> = ({

src/products/components/ProductVariantDeleteDialog/ProductVariantDeleteDialog.tsx

@@ -32,8 +32,8 @@ export interface ProductVariantDeleteDialogProps {
   confirmButtonState: ConfirmButtonTransitionState;
   open: boolean;
   name: string;
-  onClose?();
+  onClose?: () => any;
-  onConfirm?();
+  onConfirm?: () => any;
 }
 
 const ProductVariantDeleteDialog: React.FC<

src/products/components/ProductVariantMedia/ProductVariantMedia.tsx

@@ -62,7 +62,7 @@ interface ProductVariantMediaProps {
   media?: ProductMediaFragment[];
   placeholderImage?: string;
   disabled: boolean;
-  onImageAdd();
+  onImageAdd: () => any;
 }
 
 export const ProductVariantMedia: React.FC<

src/products/components/ProductVariantPage/ProductVariantPage.tsx

@@ -118,10 +118,10 @@ interface ProductVariantPageProps {
   variantDeactivatePreoderButtonState: ConfirmButtonTransitionState;
   onVariantReorder: ReorderAction;
   onAttributeSelectBlur: () => void;
-  onDelete();
+  onDelete: () => any;
-  onSubmit(data: ProductVariantUpdateSubmitData);
+  onSubmit: (data: ProductVariantUpdateSubmitData) => any;
-  onSetDefaultVariant();
+  onSetDefaultVariant: () => any;
-  onWarehouseConfigure();
+  onWarehouseConfigure: () => any;
 }
 
 const ProductVariantPage: React.FC<ProductVariantPageProps> = ({

src/staff/components/StaffDetailsPage/StaffDetailsPage.tsx

@@ -59,7 +59,7 @@ export interface StaffDetailsPageProps extends SearchPageProps {
   onDelete: () => void;
   onImageDelete: () => void;
   onSubmit: (data: StaffDetailsFormData) => SubmitPromise;
-  onImageUpload(file: File);
+  onImageUpload: (file: File) => any;
 }
 
 const StaffDetailsPage: React.FC<StaffDetailsPageProps> = ({