diff --git a/.changeset/hip-owls-knock.md b/.changeset/hip-owls-knock.md new file mode 100644 index 000000000..3349f7ada --- /dev/null +++ b/.changeset/hip-owls-knock.md @@ -0,0 +1,5 @@ +--- +"saleor-dashboard": patch +--- + +Enable method signature style ESLint rule diff --git a/.eslintrc.json b/.eslintrc.json index 150a87f5e..dcd00fe07 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -64,9 +64,6 @@ // These rules should be reviewed - tracked in // Tracked in https://github.com/saleor/saleor-dashboard/issues/3813 "@typescript-eslint/consistent-type-imports": "off", - "@typescript-eslint/indent": "off", - "@typescript-eslint/member-delimiter-style": "off", - "@typescript-eslint/method-signature-style": "off", "@typescript-eslint/no-confusing-void-expression": "off", "@typescript-eslint/no-unnecessary-type-assertion": "off", "@typescript-eslint/prefer-reduce-type-parameter": "off", diff --git a/src/apps/components/AppFrame/AppFrame.tsx b/src/apps/components/AppFrame/AppFrame.tsx index 72567e54e..b4bb6d271 100644 --- a/src/apps/components/AppFrame/AppFrame.tsx +++ b/src/apps/components/AppFrame/AppFrame.tsx @@ -22,7 +22,7 @@ interface Props { refetch?: () => void; dashboardVersion: string; coreVersion?: string; - onError?(): void; + onError?: () => void; } const getOrigin = (url: string) => new URL(url).origin; diff --git a/src/apps/components/AppPermissionsDialog/AppPermissionsDialogConfirmation.tsx b/src/apps/components/AppPermissionsDialog/AppPermissionsDialogConfirmation.tsx index b97bca709..5d0c3ce49 100644 --- a/src/apps/components/AppPermissionsDialog/AppPermissionsDialogConfirmation.tsx +++ b/src/apps/components/AppPermissionsDialog/AppPermissionsDialogConfirmation.tsx @@ -10,8 +10,8 @@ const messages = AppPermissionsDialogMessages.confirmation; interface Props { removedPermissions: PermissionEnum[]; addedPermissions: PermissionEnum[]; - onBack(): void; - onApprove(): void; + onBack: () => void; + onApprove: () => void; } export const AppPermissionsDialogConfirmation = ({ diff --git a/src/apps/components/AppPermissionsDialog/AppPermissionsDialogPermissionPicker.tsx b/src/apps/components/AppPermissionsDialog/AppPermissionsDialogPermissionPicker.tsx index 0265569b2..cc2a5889f 100644 --- a/src/apps/components/AppPermissionsDialog/AppPermissionsDialogPermissionPicker.tsx +++ b/src/apps/components/AppPermissionsDialog/AppPermissionsDialogPermissionPicker.tsx @@ -10,9 +10,9 @@ const messages = AppPermissionsDialogMessages.permissionsPicker; interface AppPermissionsDialogPermissionPickerProps { allPermissions: AppPermission[]; selected: PermissionEnum[]; - onSubmit(): void; - onChange(codes: PermissionEnum[]): void; - onClose(): void; + onSubmit: () => void; + onChange: (codes: PermissionEnum[]) => void; + onClose: () => void; } /** diff --git a/src/apps/components/InstallWithManifestFormButton/InstallWithManifestFormButton.tsx b/src/apps/components/InstallWithManifestFormButton/InstallWithManifestFormButton.tsx index b46184600..7caf6cd6e 100644 --- a/src/apps/components/InstallWithManifestFormButton/InstallWithManifestFormButton.tsx +++ b/src/apps/components/InstallWithManifestFormButton/InstallWithManifestFormButton.tsx @@ -9,7 +9,7 @@ import { messages } from "./messages"; import { useStyles } from "./styles"; interface InstallWithManifestFormButtonProps { - onSubmitted(manifestUrl: string): void; + onSubmitted: (manifestUrl: string) => void; } export const InstallWithManifestFormButton: React.FC< diff --git a/src/apps/hooks/useExtensions.ts b/src/apps/hooks/useExtensions.ts index 3c0ffcba0..cadbd8f58 100644 --- a/src/apps/hooks/useExtensions.ts +++ b/src/apps/hooks/useExtensions.ts @@ -21,11 +21,11 @@ export interface Extension { label: string; mount: AppExtensionMountEnum; url: string; - open(): void; + open: () => void; } export interface ExtensionWithParams extends Omit { - open(params: AppDetailsUrlMountQueryParams): void; + open: (params: AppDetailsUrlMountQueryParams) => void; } export const extensionMountPoints = { diff --git a/src/categories/components/CategoryCreatePage/CategoryCreatePage.tsx b/src/categories/components/CategoryCreatePage/CategoryCreatePage.tsx index b035e7278..44ad39b03 100644 --- a/src/categories/components/CategoryCreatePage/CategoryCreatePage.tsx +++ b/src/categories/components/CategoryCreatePage/CategoryCreatePage.tsx @@ -20,7 +20,7 @@ export interface CategoryCreatePageProps { disabled: boolean; saveButtonBarState: ConfirmButtonTransitionState; backUrl: string; - onSubmit(data: CategoryCreateData); + onSubmit: (data: CategoryCreateData) => any; } export const CategoryCreatePage: React.FC = ({ diff --git a/src/categories/components/CategoryDeleteDialog/CategoryDeleteDialog.tsx b/src/categories/components/CategoryDeleteDialog/CategoryDeleteDialog.tsx index 1dcbeaf7b..2432724cf 100644 --- a/src/categories/components/CategoryDeleteDialog/CategoryDeleteDialog.tsx +++ b/src/categories/components/CategoryDeleteDialog/CategoryDeleteDialog.tsx @@ -31,8 +31,8 @@ const useStyles = makeStyles( export interface CategoryDeleteDialogProps { open: boolean; name: string; - onClose(); - onConfirm(); + onClose: () => any; + onConfirm: () => any; } const CategoryDeleteDialog: React.FC = props => { diff --git a/src/categories/components/CategoryUpdatePage/CategoryUpdatePage.tsx b/src/categories/components/CategoryUpdatePage/CategoryUpdatePage.tsx index 27a1fe470..9af9e9327 100644 --- a/src/categories/components/CategoryUpdatePage/CategoryUpdatePage.tsx +++ b/src/categories/components/CategoryUpdatePage/CategoryUpdatePage.tsx @@ -45,8 +45,8 @@ export interface CategoryUpdatePageProps { onProductsDelete: () => void; onSelectProductsIds: (ids: number[], clearSelection: () => void) => void; onSelectCategoriesIds: (ids: number[], clearSelection: () => void) => void; - onImageUpload(file: File); - onDelete(); + onImageUpload: (file: File) => any; + onDelete: () => any; } const CategoriesTab = Tab(CategoryPageTab.categories); diff --git a/src/components/ActionDialog/ActionDialog.tsx b/src/components/ActionDialog/ActionDialog.tsx index d59447784..62cef106d 100644 --- a/src/components/ActionDialog/ActionDialog.tsx +++ b/src/components/ActionDialog/ActionDialog.tsx @@ -16,7 +16,7 @@ export interface ActionDialogProps extends DialogProps { title: string; variant?: ActionDialogVariant; backButtonText?: string; - onConfirm(); + onConfirm: () => any; } const ActionDialog: React.FC = props => { diff --git a/src/components/ActionDialog/DialogButtons.tsx b/src/components/ActionDialog/DialogButtons.tsx index a4c58fe99..eb0c43533 100644 --- a/src/components/ActionDialog/DialogButtons.tsx +++ b/src/components/ActionDialog/DialogButtons.tsx @@ -18,7 +18,7 @@ interface DialogButtonsProps { children?: React.ReactNode; showBackButton?: boolean; backButtonText?: string; - onConfirm(); + onConfirm: () => any; } const DialogButtons: React.FC = props => { diff --git a/src/components/AddressEdit/AddressEdit.tsx b/src/components/AddressEdit/AddressEdit.tsx index a6ee4388c..cb6223043 100644 --- a/src/components/AddressEdit/AddressEdit.tsx +++ b/src/components/AddressEdit/AddressEdit.tsx @@ -32,8 +32,8 @@ interface AddressEditProps { data: AddressTypeInput; disabled?: boolean; errors: Array; - onChange(event: React.ChangeEvent); - onCountryChange(event: React.ChangeEvent); + onChange: (event: React.ChangeEvent) => any; + onCountryChange: (event: React.ChangeEvent) => any; } const PossibleFormFields = { diff --git a/src/components/ButtonWithSelect/ButtonWithSelect.tsx b/src/components/ButtonWithSelect/ButtonWithSelect.tsx index 53c9cb7b2..94a7ea037 100644 --- a/src/components/ButtonWithSelect/ButtonWithSelect.tsx +++ b/src/components/ButtonWithSelect/ButtonWithSelect.tsx @@ -18,7 +18,7 @@ import { useStyles } from "./styles"; interface Option { label: string; disabled?: boolean; - onSelect(e: React.MouseEvent): void; + onSelect: (e: React.MouseEvent) => void; } export interface ButtonWithSelectProps diff --git a/src/components/ControlledCheckbox.tsx b/src/components/ControlledCheckbox.tsx index 59d5c1157..a9fb00917 100644 --- a/src/components/ControlledCheckbox.tsx +++ b/src/components/ControlledCheckbox.tsx @@ -11,7 +11,7 @@ export interface ControlledCheckboxProps { disabled?: boolean; checkedIcon?: React.ReactNode; testId?: string; - onChange(event: any); + onChange: (event: any) => any; } export const ControlledCheckbox: React.FC = ({ diff --git a/src/components/ControlledSwitch.tsx b/src/components/ControlledSwitch.tsx index c65e9ceb0..b1a2d3925 100644 --- a/src/components/ControlledSwitch.tsx +++ b/src/components/ControlledSwitch.tsx @@ -20,7 +20,7 @@ interface ControlledSwitchProps { name: string; secondLabel?: string | React.ReactNode; uncheckedLabel?: string | React.ReactNode; - onChange?(event: React.ChangeEvent); + onChange?: (event: React.ChangeEvent) => any; } export const ControlledSwitch: React.FC = props => { diff --git a/src/components/EditableTableCell/EditableTableCell.tsx b/src/components/EditableTableCell/EditableTableCell.tsx index f6412056c..f9f842470 100644 --- a/src/components/EditableTableCell/EditableTableCell.tsx +++ b/src/components/EditableTableCell/EditableTableCell.tsx @@ -50,7 +50,7 @@ interface EditableTableCellProps { focused?: boolean; InputProps?: TextFieldProps; value: string; - onConfirm(value: string): any; + onConfirm: (value: string) => any; } export const EditableTableCell: React.FC = props => { diff --git a/src/components/FilterCard/FilterCard.tsx b/src/components/FilterCard/FilterCard.tsx index 3e479cc23..c3f8664c8 100644 --- a/src/components/FilterCard/FilterCard.tsx +++ b/src/components/FilterCard/FilterCard.tsx @@ -6,7 +6,7 @@ import React from "react"; import { useIntl } from "react-intl"; export interface FilterCardProps { - handleClear(); + handleClear: () => any; } const FilterCard: React.FC = ({ children, handleClear }) => { diff --git a/src/components/MultiSelectField/MultiSelectField.tsx b/src/components/MultiSelectField/MultiSelectField.tsx index 28b0fdefa..8c89235b7 100644 --- a/src/components/MultiSelectField/MultiSelectField.tsx +++ b/src/components/MultiSelectField/MultiSelectField.tsx @@ -44,7 +44,7 @@ interface MultiSelectFieldProps { name?: string; selectProps?: SelectProps; value?: string[]; - onChange(event: any); + onChange: (event: any) => any; } export const MultiSelectField: React.FC = props => { diff --git a/src/components/PhoneField/PhoneField.tsx b/src/components/PhoneField/PhoneField.tsx index dba7d278a..e74296b85 100644 --- a/src/components/PhoneField/PhoneField.tsx +++ b/src/components/PhoneField/PhoneField.tsx @@ -21,7 +21,7 @@ interface PhoneFieldProps { number: string; prefixes: string[]; label?: string; - onChange(event: React.ChangeEvent); + onChange: (event: React.ChangeEvent) => any; } const PhoneField: React.FC = props => { diff --git a/src/components/PriceField/PriceField.tsx b/src/components/PriceField/PriceField.tsx index 5c53eae87..abe386582 100644 --- a/src/components/PriceField/PriceField.tsx +++ b/src/components/PriceField/PriceField.tsx @@ -43,7 +43,7 @@ export interface PriceFieldProps { inputProps?: InputProps["inputProps"]; InputLabelProps?: InputLabelProps; required?: boolean; - onChange(event: any); + onChange: (event: any) => any; } export const PriceField: React.FC = props => { diff --git a/src/components/RowNumberSelect/RowNumberSelect.tsx b/src/components/RowNumberSelect/RowNumberSelect.tsx index dabbcd45f..1e1f6fdf5 100644 --- a/src/components/RowNumberSelect/RowNumberSelect.tsx +++ b/src/components/RowNumberSelect/RowNumberSelect.tsx @@ -34,7 +34,7 @@ interface RowNumberSelectProps { choices: number[]; className?: string; rowNumber: number; - onChange(value: number); + onChange: (value: number) => any; } const RowNumberSelect: React.FC = ({ diff --git a/src/components/SeoForm/SeoForm.tsx b/src/components/SeoForm/SeoForm.tsx index 4b19dda7f..08ce368a8 100644 --- a/src/components/SeoForm/SeoForm.tsx +++ b/src/components/SeoForm/SeoForm.tsx @@ -54,8 +54,8 @@ interface SeoFormProps { slug: string; slugPlaceholder?: string; titlePlaceholder: string; - onChange(event: any); - onClick?(); + onChange: (event: any) => any; + onClick?: () => any; } export const SeoForm: React.FC = props => { diff --git a/src/components/SingleSelectField/SingleSelectField.tsx b/src/components/SingleSelectField/SingleSelectField.tsx index 03b306fb7..8693f6158 100644 --- a/src/components/SingleSelectField/SingleSelectField.tsx +++ b/src/components/SingleSelectField/SingleSelectField.tsx @@ -60,7 +60,7 @@ interface SingleSelectFieldProps { placeholder?: string; value?: string; InputProps?: OutlinedInputProps; - onChange(event: any); + onChange: (event: any) => any; } export const SingleSelectField: React.FC = props => { diff --git a/src/components/TablePagination/TablePaginationActions.tsx b/src/components/TablePagination/TablePaginationActions.tsx index 57bc669f3..fcb85b286 100644 --- a/src/components/TablePagination/TablePaginationActions.tsx +++ b/src/components/TablePagination/TablePaginationActions.tsx @@ -58,8 +58,8 @@ export interface TablePaginationActionsProps { hasNextPage: boolean; hasPreviousPage: boolean; nextIconButtonProps?: any; - onNextPage(event); - onPreviousPage(event); + onNextPage: (event) => any; + onPreviousPage: (event) => any; } export const TablePaginationActions: React.FC< diff --git a/src/components/Timeline/Timeline.tsx b/src/components/Timeline/Timeline.tsx index 19e6abc31..c3ea76836 100644 --- a/src/components/Timeline/Timeline.tsx +++ b/src/components/Timeline/Timeline.tsx @@ -67,8 +67,8 @@ interface TimelineAddNoteProps { disabled?: boolean; message: string; reset: () => void; - onChange(event: React.ChangeEvent); - onSubmit(event: React.FormEvent); + onChange: (event: React.ChangeEvent) => any; + onSubmit: (event: React.FormEvent) => any; } export const Timeline: React.FC = props => { diff --git a/src/customers/components/CustomerCreateAddress/CustomerCreateAddress.tsx b/src/customers/components/CustomerCreateAddress/CustomerCreateAddress.tsx index 915fc9243..fb5630d1c 100644 --- a/src/customers/components/CustomerCreateAddress/CustomerCreateAddress.tsx +++ b/src/customers/components/CustomerCreateAddress/CustomerCreateAddress.tsx @@ -26,8 +26,8 @@ export interface CustomerCreateAddressProps { data: AddressTypeInput; disabled: boolean; errors: AccountErrorFragment[]; - onChange(event: React.ChangeEvent); - onCountryChange(event: React.ChangeEvent); + onChange: (event: React.ChangeEvent) => any; + onCountryChange: (event: React.ChangeEvent) => any; } const CustomerCreateAddress: React.FC = props => { diff --git a/src/featureFlags/Strategy.ts b/src/featureFlags/Strategy.ts index 071d70c6e..bdbc9a1be 100644 --- a/src/featureFlags/Strategy.ts +++ b/src/featureFlags/Strategy.ts @@ -1,9 +1,9 @@ import { FlagList } from "./availableFlags"; export interface Strategy { - fetchAll(): Promise; + fetchAll: () => Promise; } export interface PersistableStrategy extends Strategy { - store?(flags: FlagList): Promise; + store?: (flags: FlagList) => Promise; } diff --git a/src/orders/components/OrderChangeWarehouseDialog/OrderChangeWarehouseDialog.tsx b/src/orders/components/OrderChangeWarehouseDialog/OrderChangeWarehouseDialog.tsx index deb89af8d..b6f3c9f08 100644 --- a/src/orders/components/OrderChangeWarehouseDialog/OrderChangeWarehouseDialog.tsx +++ b/src/orders/components/OrderChangeWarehouseDialog/OrderChangeWarehouseDialog.tsx @@ -44,7 +44,7 @@ export interface OrderChangeWarehouseDialogProps { line: OrderFulfillLineFragment; currentWarehouseId: string; onConfirm: (warehouse: WarehouseFragment) => void; - onClose(); + onClose: () => any; } export const OrderChangeWarehouseDialog: React.FC< diff --git a/src/orders/components/OrderCustomerAddressesEditDialog/OrderCustomerAddressesEditDialog.tsx b/src/orders/components/OrderCustomerAddressesEditDialog/OrderCustomerAddressesEditDialog.tsx index f13e4f2cb..63a76fb29 100644 --- a/src/orders/components/OrderCustomerAddressesEditDialog/OrderCustomerAddressesEditDialog.tsx +++ b/src/orders/components/OrderCustomerAddressesEditDialog/OrderCustomerAddressesEditDialog.tsx @@ -64,10 +64,10 @@ export interface OrderCustomerAddressesEditDialogProps { customerAddresses?: AddressFragment[]; defaultShippingAddress?: Node; defaultBillingAddress?: Node; - onClose(); - onConfirm( + onClose: () => any; + onConfirm: ( data: Partial, - ): SubmitPromise; + ) => SubmitPromise; } const defaultSearchState: OrderCustomerSearchAddressState = { diff --git a/src/orders/components/OrderCustomerAddressesEditDialog/OrderCustomerAddressesSearch.tsx b/src/orders/components/OrderCustomerAddressesEditDialog/OrderCustomerAddressesSearch.tsx index 99721cd5e..c4b69903a 100644 --- a/src/orders/components/OrderCustomerAddressesEditDialog/OrderCustomerAddressesSearch.tsx +++ b/src/orders/components/OrderCustomerAddressesEditDialog/OrderCustomerAddressesSearch.tsx @@ -35,7 +35,7 @@ export interface OrderCustomerAddressesSearchProps { customerAddresses: AddressFragment[]; onChangeCustomerShippingAddress: (customerAddress: AddressFragment) => void; onChangeCustomerBillingAddress: (customerAddress: AddressFragment) => void; - exitSearch(); + exitSearch: () => any; } const OrderCustomerAddressesSearch: React.FC< diff --git a/src/orders/components/OrderCustomerChangeDialog/OrderCustomerChangeDialog.tsx b/src/orders/components/OrderCustomerChangeDialog/OrderCustomerChangeDialog.tsx index e04bb3bbf..67d25d04c 100644 --- a/src/orders/components/OrderCustomerChangeDialog/OrderCustomerChangeDialog.tsx +++ b/src/orders/components/OrderCustomerChangeDialog/OrderCustomerChangeDialog.tsx @@ -25,7 +25,7 @@ import { useStyles } from "./styles"; export interface OrderCustomerChangeDialogProps { open: boolean; onConfirm: (data: OrderCustomerChangeData) => void; - onClose(); + onClose: () => any; } const OrderCustomerChangeDialog: React.FC< diff --git a/src/orders/components/OrderDetailsPage/OrderDetailsPage.tsx b/src/orders/components/OrderDetailsPage/OrderDetailsPage.tsx index fa3aff956..64f612752 100644 --- a/src/orders/components/OrderDetailsPage/OrderDetailsPage.tsx +++ b/src/orders/components/OrderDetailsPage/OrderDetailsPage.tsx @@ -64,27 +64,27 @@ export interface OrderDetailsPageProps { ) => void; onOrderLineRemove?: (id: string) => void; onShippingMethodEdit?: () => void; - onBillingAddressEdit(); - onFulfillmentApprove(id: string); - onFulfillmentCancel(id: string); - onFulfillmentTrackingNumberUpdate(id: string); - onOrderFulfill(); - onProductClick?(id: string); - onPaymentCapture(); - onMarkAsPaid(); - onPaymentRefund(); - onPaymentVoid(); - onShippingAddressEdit(); - onOrderCancel(); - onNoteAdd(data: HistoryFormData); - onProfileView(); - onOrderReturn(); - onInvoiceClick(invoiceId: string); - onInvoiceGenerate(); - onInvoiceSend(invoiceId: string); - onTransactionAction(transactionId: string, actionType: TransactionActionEnum); - onAddManualTransaction(); - onSubmit(data: MetadataIdSchema): SubmitPromise; + onBillingAddressEdit: () => any; + onFulfillmentApprove: (id: string) => any; + onFulfillmentCancel: (id: string) => any; + onFulfillmentTrackingNumberUpdate: (id: string) => any; + onOrderFulfill: () => any; + onProductClick?: (id: string) => any; + onPaymentCapture: () => any; + onMarkAsPaid: () => any; + onPaymentRefund: () => any; + onPaymentVoid: () => any; + onShippingAddressEdit: () => any; + onOrderCancel: () => any; + onNoteAdd: (data: HistoryFormData) => any; + onProfileView: () => any; + onOrderReturn: () => any; + onInvoiceClick: (invoiceId: string) => any; + onInvoiceGenerate: () => any; + onInvoiceSend: (invoiceId: string) => any; + onTransactionAction: (transactionId: string, actionType: TransactionActionEnum) => any; + onAddManualTransaction: () => any; + onSubmit: (data: MetadataIdSchema) => SubmitPromise; } const OrderDetailsPage: React.FC = props => { diff --git a/src/orders/components/OrderFulfillStockExceededDialog/OrderFulfillStockExceededDialog.tsx b/src/orders/components/OrderFulfillStockExceededDialog/OrderFulfillStockExceededDialog.tsx index 40f4f34ea..fa0e529aa 100644 --- a/src/orders/components/OrderFulfillStockExceededDialog/OrderFulfillStockExceededDialog.tsx +++ b/src/orders/components/OrderFulfillStockExceededDialog/OrderFulfillStockExceededDialog.tsx @@ -27,8 +27,8 @@ export interface OrderFulfillStockExceededDialogProps { open: boolean; formsetData: OrderFulfillStockFormsetData; confirmButtonState: ConfirmButtonTransitionState; - onSubmit(); - onClose(); + onSubmit: () => any; + onClose: () => any; } const OrderFulfillStockExceededDialog: React.FC< diff --git a/src/orders/components/OrderFulfilledProductsCard/ActionButtons.tsx b/src/orders/components/OrderFulfilledProductsCard/ActionButtons.tsx index 366b1b292..beb3fb002 100644 --- a/src/orders/components/OrderFulfilledProductsCard/ActionButtons.tsx +++ b/src/orders/components/OrderFulfilledProductsCard/ActionButtons.tsx @@ -17,8 +17,8 @@ interface AcionButtonsProps { orderIsPaid?: boolean; fulfillmentAllowUnpaid: boolean; hasTransactions: boolean; - onTrackingCodeAdd(); - onApprove(); + onTrackingCodeAdd: () => any; + onApprove: () => any; } const statusesToShow = [ diff --git a/src/orders/components/OrderFulfillmentApproveDialog/OrderFulfillmentApproveDialog.tsx b/src/orders/components/OrderFulfillmentApproveDialog/OrderFulfillmentApproveDialog.tsx index acbff8644..6a5069286 100644 --- a/src/orders/components/OrderFulfillmentApproveDialog/OrderFulfillmentApproveDialog.tsx +++ b/src/orders/components/OrderFulfillmentApproveDialog/OrderFulfillmentApproveDialog.tsx @@ -29,8 +29,8 @@ export interface OrderFulfillmentAcceptDialogProps { confirmButtonState: ConfirmButtonTransitionState; errors: OrderErrorFragment[]; open: boolean; - onClose(): void; - onConfirm(data: OrderFulfillmentAcceptDialogFormData): void; + onClose: () => void; + onConfirm: (data: OrderFulfillmentAcceptDialogFormData) => void; } const OrderFulfillmentAcceptDialog: React.FC< diff --git a/src/orders/components/OrderFulfillmentCancelDialog/OrderFulfillmentCancelDialog.tsx b/src/orders/components/OrderFulfillmentCancelDialog/OrderFulfillmentCancelDialog.tsx index 3eb4c6b6c..1185495c0 100644 --- a/src/orders/components/OrderFulfillmentCancelDialog/OrderFulfillmentCancelDialog.tsx +++ b/src/orders/components/OrderFulfillmentCancelDialog/OrderFulfillmentCancelDialog.tsx @@ -46,8 +46,8 @@ export interface OrderFulfillmentCancelDialogProps { errors: OrderErrorFragment[]; open: boolean; warehouses: WarehouseFragment[]; - onClose(); - onConfirm(data: OrderFulfillmentCancelDialogFormData); + onClose: () => any; + onConfirm: (data: OrderFulfillmentCancelDialogFormData) => any; } const OrderFulfillmentCancelDialog: React.FC< diff --git a/src/orders/components/OrderFulfillmentTrackingDialog/OrderFulfillmentTrackingDialog.tsx b/src/orders/components/OrderFulfillmentTrackingDialog/OrderFulfillmentTrackingDialog.tsx index a6829df0a..ec3f349ef 100644 --- a/src/orders/components/OrderFulfillmentTrackingDialog/OrderFulfillmentTrackingDialog.tsx +++ b/src/orders/components/OrderFulfillmentTrackingDialog/OrderFulfillmentTrackingDialog.tsx @@ -31,8 +31,8 @@ export interface OrderFulfillmentTrackingDialogProps { errors: OrderErrorFragment[]; open: boolean; trackingNumber: string; - onClose(); - onConfirm(data: FormData); + onClose: () => any; + onConfirm: (data: FormData) => any; } const OrderFulfillmentTrackingDialog: React.FC< diff --git a/src/orders/components/OrderPaymentOrTransaction/OrderPaymentOrTransaction.tsx b/src/orders/components/OrderPaymentOrTransaction/OrderPaymentOrTransaction.tsx index fe98bbccd..4bfe82547 100644 --- a/src/orders/components/OrderPaymentOrTransaction/OrderPaymentOrTransaction.tsx +++ b/src/orders/components/OrderPaymentOrTransaction/OrderPaymentOrTransaction.tsx @@ -14,12 +14,12 @@ import { OrderTransactionsWrapper } from "./OrderTransactionsWrapper"; export interface OrderPaymentOrTransactionProps { order: OrderDetailsFragment; shop: OrderDetailsQuery["shop"]; - onTransactionAction(transactionId: string, actionType: TransactionActionEnum); - onPaymentCapture(); - onPaymentVoid(); - onPaymentRefund(); - onMarkAsPaid(); - onAddManualTransaction(); + onTransactionAction: (transactionId: string, actionType: TransactionActionEnum) => any; + onPaymentCapture: () => any; + onPaymentVoid: () => any; + onPaymentRefund: () => any; + onMarkAsPaid: () => any; + onAddManualTransaction: () => any; } export const OrderPaymentOrTransaction: React.FC< diff --git a/src/orders/components/OrderPaymentOrTransaction/OrderTransactionsWrapper.tsx b/src/orders/components/OrderPaymentOrTransaction/OrderTransactionsWrapper.tsx index 28361ca28..97297a40a 100644 --- a/src/orders/components/OrderPaymentOrTransaction/OrderTransactionsWrapper.tsx +++ b/src/orders/components/OrderPaymentOrTransaction/OrderTransactionsWrapper.tsx @@ -20,11 +20,11 @@ import { getFilteredPayments } from "./utils"; interface OrderTransactionsWrapper { order: OrderDetailsFragment; shop: OrderDetailsQuery["shop"]; - onTransactionAction(transactionId: string, actionType: TransactionActionEnum); - onPaymentCapture(); - onMarkAsPaid(); - onPaymentVoid(); - onAddManualTransaction(); + onTransactionAction: (transactionId: string, actionType: TransactionActionEnum) => any; + onPaymentCapture: () => any; + onMarkAsPaid: () => any; + onPaymentVoid: () => any; + onAddManualTransaction: () => any; } export const OrderTransactionsWrapper: React.FC = ({ diff --git a/src/orders/components/OrderPaymentVoidDialog/OrderPaymentVoidDialog.tsx b/src/orders/components/OrderPaymentVoidDialog/OrderPaymentVoidDialog.tsx index dc36a37c9..222ef53bb 100644 --- a/src/orders/components/OrderPaymentVoidDialog/OrderPaymentVoidDialog.tsx +++ b/src/orders/components/OrderPaymentVoidDialog/OrderPaymentVoidDialog.tsx @@ -22,8 +22,8 @@ export interface OrderPaymentVoidDialogProps { confirmButtonState: ConfirmButtonTransitionState; errors: OrderErrorFragment[]; open: boolean; - onClose?(); - onConfirm?(); + onClose?: () => any; + onConfirm?: () => any; } const OrderPaymentVoidDialog: React.FC = ({ diff --git a/src/orders/components/OrderReturnPage/OrderReturnRefundItemsCard/ReturnItemsCard.tsx b/src/orders/components/OrderReturnPage/OrderReturnRefundItemsCard/ReturnItemsCard.tsx index b70a57537..e1b852957 100644 --- a/src/orders/components/OrderReturnPage/OrderReturnRefundItemsCard/ReturnItemsCard.tsx +++ b/src/orders/components/OrderReturnPage/OrderReturnRefundItemsCard/ReturnItemsCard.tsx @@ -103,7 +103,7 @@ interface OrderReturnRefundLinesCardProps { itemsSelections: FormsetReplacementData; itemsQuantities: FormsetQuantityData; onChangeSelected: FormsetChange; - onSetMaxQuantity(); + onSetMaxQuantity: () => any; } const ItemsCard: React.FC = ({ diff --git a/src/orders/components/OrderReturnPage/components/ItemsCard/ItemsCard.tsx b/src/orders/components/OrderReturnPage/components/ItemsCard/ItemsCard.tsx index e5a96e0ff..2fe59f1c2 100644 --- a/src/orders/components/OrderReturnPage/components/ItemsCard/ItemsCard.tsx +++ b/src/orders/components/OrderReturnPage/components/ItemsCard/ItemsCard.tsx @@ -44,7 +44,7 @@ interface OrderReturnRefundLinesCardProps { itemsSelections: FormsetReplacementData; itemsQuantities: FormsetQuantityData; onChangeSelected: FormsetChange; - onSetMaxQuantity(); + onSetMaxQuantity: () => any; } export const ItemsCard: React.FC = ({ diff --git a/src/orders/components/OrderShippingMethodEditDialog/OrderShippingMethodEditDialog.tsx b/src/orders/components/OrderShippingMethodEditDialog/OrderShippingMethodEditDialog.tsx index 1682c365c..a34b194ac 100644 --- a/src/orders/components/OrderShippingMethodEditDialog/OrderShippingMethodEditDialog.tsx +++ b/src/orders/components/OrderShippingMethodEditDialog/OrderShippingMethodEditDialog.tsx @@ -66,8 +66,8 @@ export interface OrderShippingMethodEditDialogProps { open: boolean; shippingMethod: string; shippingMethods?: OrderDetailsFragment["shippingMethods"]; - onClose(); - onSubmit?(data: FormData); + onClose: () => any; + onSubmit?: (data: FormData) => any; } const OrderShippingMethodEditDialog: React.FC< diff --git a/src/products/components/ProductCreatePage/ProductCreatePage.tsx b/src/products/components/ProductCreatePage/ProductCreatePage.tsx index 248960b78..a1ccc7c2c 100644 --- a/src/products/components/ProductCreatePage/ProductCreatePage.tsx +++ b/src/products/components/ProductCreatePage/ProductCreatePage.tsx @@ -95,7 +95,7 @@ interface ProductCreatePageProps { onAttributeSelectBlur: () => void; onCloseDialog: (currentParams?: ProductCreateUrlQueryParams) => void; onSelectProductType: (productTypeId: string) => void; - onSubmit?(data: ProductCreateData); + onSubmit?: (data: ProductCreateData) => any; } export const ProductCreatePage: React.FC = ({ diff --git a/src/products/components/ProductDetailsForm/ProductDetailsForm.tsx b/src/products/components/ProductDetailsForm/ProductDetailsForm.tsx index b3f034bb1..a62320f0f 100644 --- a/src/products/components/ProductDetailsForm/ProductDetailsForm.tsx +++ b/src/products/components/ProductDetailsForm/ProductDetailsForm.tsx @@ -20,7 +20,7 @@ interface ProductDetailsFormProps { disabled?: boolean; errors: ProductErrorFragment[]; - onChange(event: any); + onChange: (event: any) => any; } export const ProductDetailsForm: React.FC = ({ diff --git a/src/products/components/ProductMedia/ProductMedia.tsx b/src/products/components/ProductMedia/ProductMedia.tsx index 4145753c9..ff5d53957 100644 --- a/src/products/components/ProductMedia/ProductMedia.tsx +++ b/src/products/components/ProductMedia/ProductMedia.tsx @@ -71,8 +71,8 @@ interface ProductMediaProps { getImageEditUrl: (id: string) => string; onImageDelete: (id: string) => () => void; onImageReorder?: ReorderAction; - onImageUpload(file: File); - openMediaUrlModal(); + onImageUpload: (file: File) => any; + openMediaUrlModal: () => any; } const ProductMedia: React.FC = props => { diff --git a/src/products/components/ProductUpdatePage/ProductUpdatePage.tsx b/src/products/components/ProductUpdatePage/ProductUpdatePage.tsx index c785cb270..23352faee 100644 --- a/src/products/components/ProductUpdatePage/ProductUpdatePage.tsx +++ b/src/products/components/ProductUpdatePage/ProductUpdatePage.tsx @@ -113,11 +113,11 @@ export interface ProductUpdatePageProps { onSubmit: (data: ProductUpdateSubmitData) => SubmitPromise; onVariantShow: (id: string) => void; onAttributeSelectBlur: () => void; - onDelete(); - onImageReorder?(event: { oldIndex: number; newIndex: number }); - onImageUpload(file: File); - onMediaUrlUpload(mediaUrl: string); - onSeoClick?(); + onDelete: () => any; + onImageReorder?: (event: { oldIndex: number; newIndex: number }) => any; + onImageUpload: (file: File) => any; + onMediaUrlUpload: (mediaUrl: string) => any; + onSeoClick?: () => any; } export const ProductUpdatePage: React.FC = ({ diff --git a/src/products/components/ProductVariantDeleteDialog/ProductVariantDeleteDialog.tsx b/src/products/components/ProductVariantDeleteDialog/ProductVariantDeleteDialog.tsx index 1497e2ace..3fedae158 100644 --- a/src/products/components/ProductVariantDeleteDialog/ProductVariantDeleteDialog.tsx +++ b/src/products/components/ProductVariantDeleteDialog/ProductVariantDeleteDialog.tsx @@ -32,8 +32,8 @@ export interface ProductVariantDeleteDialogProps { confirmButtonState: ConfirmButtonTransitionState; open: boolean; name: string; - onClose?(); - onConfirm?(); + onClose?: () => any; + onConfirm?: () => any; } const ProductVariantDeleteDialog: React.FC< diff --git a/src/products/components/ProductVariantMedia/ProductVariantMedia.tsx b/src/products/components/ProductVariantMedia/ProductVariantMedia.tsx index 5f19cd0fe..e88b1792c 100644 --- a/src/products/components/ProductVariantMedia/ProductVariantMedia.tsx +++ b/src/products/components/ProductVariantMedia/ProductVariantMedia.tsx @@ -62,7 +62,7 @@ interface ProductVariantMediaProps { media?: ProductMediaFragment[]; placeholderImage?: string; disabled: boolean; - onImageAdd(); + onImageAdd: () => any; } export const ProductVariantMedia: React.FC< diff --git a/src/products/components/ProductVariantPage/ProductVariantPage.tsx b/src/products/components/ProductVariantPage/ProductVariantPage.tsx index 29deb39ea..c79219f79 100644 --- a/src/products/components/ProductVariantPage/ProductVariantPage.tsx +++ b/src/products/components/ProductVariantPage/ProductVariantPage.tsx @@ -118,10 +118,10 @@ interface ProductVariantPageProps { variantDeactivatePreoderButtonState: ConfirmButtonTransitionState; onVariantReorder: ReorderAction; onAttributeSelectBlur: () => void; - onDelete(); - onSubmit(data: ProductVariantUpdateSubmitData); - onSetDefaultVariant(); - onWarehouseConfigure(); + onDelete: () => any; + onSubmit: (data: ProductVariantUpdateSubmitData) => any; + onSetDefaultVariant: () => any; + onWarehouseConfigure: () => any; } const ProductVariantPage: React.FC = ({ diff --git a/src/staff/components/StaffDetailsPage/StaffDetailsPage.tsx b/src/staff/components/StaffDetailsPage/StaffDetailsPage.tsx index 7ce00142c..73947700d 100644 --- a/src/staff/components/StaffDetailsPage/StaffDetailsPage.tsx +++ b/src/staff/components/StaffDetailsPage/StaffDetailsPage.tsx @@ -59,7 +59,7 @@ export interface StaffDetailsPageProps extends SearchPageProps { onDelete: () => void; onImageDelete: () => void; onSubmit: (data: StaffDetailsFormData) => SubmitPromise; - onImageUpload(file: File); + onImageUpload: (file: File) => any; } const StaffDetailsPage: React.FC = ({