diff --git a/CHANGELOG.md b/CHANGELOG.md index 3b2f13ae1..2425e4da9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ All notable, unreleased changes to this project will be documented in this file. - Add navigator - #267 by @dominik-zeglen - Fix voucher limit - #271 by @dominik-zeglen - Allow multiple images to be uploaded - #277 by @dominik-zeglen +- Fix dropdown clickable areas - #281 by @dominik-zeglen - Use eslint - #285 by @dominik-zeglen ## 2.0.0 diff --git a/src/components/MultiAutocompleteSelectField/MultiAutocompleteSelectFieldContent.tsx b/src/components/MultiAutocompleteSelectField/MultiAutocompleteSelectFieldContent.tsx index cb99854fe..2f3032c11 100644 --- a/src/components/MultiAutocompleteSelectField/MultiAutocompleteSelectFieldContent.tsx +++ b/src/components/MultiAutocompleteSelectField/MultiAutocompleteSelectFieldContent.tsx @@ -70,7 +70,8 @@ const useStyles = makeStyles( padding: 8 }, hide: { - opacity: 0 + opacity: 0, + zIndex: -1 }, hr: { margin: theme.spacing(1, 0) @@ -275,17 +276,19 @@ const MultiAutocompleteSelectFieldContent: React.FC< )} -
-
- + {choices.length > maxMenuItems && ( +
+
+ +
-
+ )} ); }; diff --git a/src/components/SingleAutocompleteSelectField/SingleAutocompleteSelectFieldContent.tsx b/src/components/SingleAutocompleteSelectField/SingleAutocompleteSelectFieldContent.tsx index 35b56e9e9..602a24b47 100644 --- a/src/components/SingleAutocompleteSelectField/SingleAutocompleteSelectFieldContent.tsx +++ b/src/components/SingleAutocompleteSelectField/SingleAutocompleteSelectFieldContent.tsx @@ -62,7 +62,8 @@ const useStyles = makeStyles( padding: 8 }, hide: { - opacity: 0 + opacity: 0, + zIndex: -1 }, hr: { margin: theme.spacing(1, 0) @@ -228,17 +229,19 @@ const SingleAutocompleteSelectFieldContent: React.FC< )}
-
-
- + {choices.length > maxMenuItems && ( +
+
+ +
-
+ )} ); }; diff --git a/src/products/views/ProductVariant.tsx b/src/products/views/ProductVariant.tsx index 317ec0c6b..5ace13fb2 100644 --- a/src/products/views/ProductVariant.tsx +++ b/src/products/views/ProductVariant.tsx @@ -1,4 +1,4 @@ -import React from "react"; +import React, { useEffect, useState } from "react"; import { useIntl } from "react-intl"; import placeholderImg from "@assets/images/placeholder255x255.png"; @@ -35,6 +35,10 @@ export const ProductVariant: React.FC = ({ const navigate = useNavigator(); const notify = useNotifier(); const intl = useIntl(); + const [errors, setErrors] = useState([]); + useEffect(() => { + setErrors([]); + }, [variantId]); return ( = ({ navigate(productUrl(productId)); }; const handleUpdate = (data: VariantUpdate) => { - if (!maybe(() => data.productVariantUpdate.productErrors.length)) { + if (!data.productVariantUpdate.productErrors.length) { notify({ text: intl.formatMessage(commonMessages.savedChanges) }); + } else { + setErrors(data.productVariantUpdate.productErrors); } }; @@ -107,12 +113,7 @@ export const ProductVariant: React.FC = ({ <> data.productVariant.name)} /> - updateVariant.opts.data.productVariantUpdate - .productErrors, - [] - )} + errors={errors} saveButtonBarState={formTransitionState} loading={disableFormSave} placeholderImage={placeholderImg} diff --git a/src/storybook/__snapshots__/Stories.test.ts.snap b/src/storybook/__snapshots__/Stories.test.ts.snap index 6487a2acc..0796e9af9 100644 --- a/src/storybook/__snapshots__/Stories.test.ts.snap +++ b/src/storybook/__snapshots__/Stories.test.ts.snap @@ -3051,17 +3051,6 @@ exports[`Storyshots Generics / Multiple select with autocomplete no data 1`] = `
-
-
- -
-
@@ -4980,17 +4969,6 @@ exports[`Storyshots Generics / Select with autocomplete no data 1`] = ` No results found -
-
- -
-