djkato/saleor-dashboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add metadata input filtering before create/update (#1495)

Browse source 
* Add metadata input filtering before create/update

* Small refactor

* remove unnecessary return
This commit is contained in:
Wojciech Mista 2021-10-19 15:23:02 +02:00 committed by GitHub
parent 13c63283a9
commit fe3de902b1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/utils/handlers/filterMetadataArray.ts Normal file
View file

@ -0,0 +1,4 @@
import { MetadataInput } from "@saleor/types/globalTypes";
export const filterMetadataArray = (metadataInputs: MetadataInput[]) =>
metadataInputs.filter(input => !!input.key);

5
src/utils/handlers/metadataCreateHandler.ts
View file

@ -9,6 +9,7 @@ import {
UpdatePrivateMetadata, UpdatePrivateMetadata,
UpdatePrivateMetadataVariables UpdatePrivateMetadataVariables
} from "../metadata/types/UpdatePrivateMetadata"; } from "../metadata/types/UpdatePrivateMetadata";
import { filterMetadataArray } from "./filterMetadataArray";
function createMetadataCreateHandler<T extends MetadataFormData>( function createMetadataCreateHandler<T extends MetadataFormData>(
create: (data: T) => Promise<string>, create: (data: T) => Promise<string>,
@ -29,7 +30,7 @@ function createMetadataCreateHandler<T extends MetadataFormData>(
const updateMetaResult = await setMetadata({ const updateMetaResult = await setMetadata({
variables: { variables: {
id, id,
input: data.metadata, input: filterMetadataArray(data.metadata),
keysToDelete: [] keysToDelete: []
} }
}); });
@ -47,7 +48,7 @@ function createMetadataCreateHandler<T extends MetadataFormData>(
const updatePrivateMetaResult = await setPrivateMetadata({ const updatePrivateMetaResult = await setPrivateMetadata({
variables: { variables: {
id, id,
input: data.privateMetadata, input: filterMetadataArray(data.privateMetadata),
keysToDelete: [] keysToDelete: []
} }
}); });

6
src/utils/handlers/metadataUpdateHandler.ts
View file

@ -12,6 +12,7 @@ import {
UpdatePrivateMetadata, UpdatePrivateMetadata,
UpdatePrivateMetadataVariables UpdatePrivateMetadataVariables
} from "../metadata/types/UpdatePrivateMetadata"; } from "../metadata/types/UpdatePrivateMetadata";
import { filterMetadataArray } from "./filterMetadataArray";
interface ObjectWithMetadata { interface ObjectWithMetadata {
id: string; id: string;
@ -47,9 +48,10 @@ function createMetadataUpdateHandler<TData extends MetadataFormData, TError>(
const updateMetaResult = await updateMetadata({ const updateMetaResult = await updateMetadata({
id: initial.id, id: initial.id,
input: data.metadata, input: filterMetadataArray(data.metadata),
keysToDelete: keyDiff.removed keysToDelete: keyDiff.removed
}); });
const updateMetaErrors = [ const updateMetaErrors = [
...(updateMetaResult.data.deleteMetadata.errors || []), ...(updateMetaResult.data.deleteMetadata.errors || []),
...(updateMetaResult.data.updateMetadata.errors || []) ...(updateMetaResult.data.updateMetadata.errors || [])
@ -68,7 +70,7 @@ function createMetadataUpdateHandler<TData extends MetadataFormData, TError>(
const updatePrivateMetaResult = await updatePrivateMetadata({ const updatePrivateMetaResult = await updatePrivateMetadata({
id: initial.id, id: initial.id,
input: data.privateMetadata, input: filterMetadataArray(data.privateMetadata),
keysToDelete: keyDiff.removed keysToDelete: keyDiff.removed
}); });