From 44d79897f24ff66a1196d27c9bbbe43247bda8f4 Mon Sep 17 00:00:00 2001 From: dominik-zeglen Date: Fri, 31 Jan 2020 16:20:14 +0100 Subject: [PATCH 1/2] Fix column picker errors --- src/components/ColumnPicker/ColumnPicker.tsx | 55 +++++++++---------- .../ColumnPicker/ColumnPickerContent.tsx | 2 + 2 files changed, 28 insertions(+), 29 deletions(-) diff --git a/src/components/ColumnPicker/ColumnPicker.tsx b/src/components/ColumnPicker/ColumnPicker.tsx index f2a1c9434..3dc2cf759 100644 --- a/src/components/ColumnPicker/ColumnPicker.tsx +++ b/src/components/ColumnPicker/ColumnPicker.tsx @@ -77,30 +77,27 @@ const ColumnPicker: React.FC = props => { }; return ( -
- setExpansionState(prevState => !prevState)} - /> - - {({ TransitionProps, placement }) => ( - - setExpansionState(false)} - mouseEvent="onClick" + setExpansionState(false)}> +
+ setExpansionState(prevState => !prevState)} + /> + + {({ TransitionProps, placement }) => ( + = props => { onReset={handleReset} onSave={handleSave} /> - - - )} - -
+
+ )} +
+
+ ); }; diff --git a/src/components/ColumnPicker/ColumnPickerContent.tsx b/src/components/ColumnPicker/ColumnPickerContent.tsx index 26eada3f1..971a57d3d 100644 --- a/src/components/ColumnPicker/ColumnPickerContent.tsx +++ b/src/components/ColumnPicker/ColumnPickerContent.tsx @@ -137,6 +137,7 @@ const ColumnPickerContent: React.FC = props => { name={column.value} label={column.label} onChange={() => onColumnToggle(column.value)} + key={column.value} /> ))} {loading && ( @@ -160,6 +161,7 @@ const ColumnPickerContent: React.FC = props => { name={column.value} label={column.label} onChange={() => onColumnToggle(column.value)} + key={column.value} /> ))} From 749ea98b4a87ab095fce7e055760ae813f8503e9 Mon Sep 17 00:00:00 2001 From: dominik-zeglen Date: Fri, 31 Jan 2020 16:22:41 +0100 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 441a948ba..3c9b8de5f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ All notable, unreleased changes to this project will be documented in this file. - Add filtering to views - #361 by @dominik-zeglen - Do not render password change if authenticating - #378 by @dominik-zeglen - Fix crash when one product is selected - #391 by @dominik-zeglen +- Fix column picker errors - #393 by @dominik-zeglen ## 2.0.0