From f85ca42d3610d64482f19b43b9c643c2f58d6384 Mon Sep 17 00:00:00 2001
From: Dawid Tarasiuk <tarasiukdawid@gmail.com>
Date: Fri, 9 Oct 2020 13:11:48 +0200
Subject: [PATCH] Use non negative value change handler for quantity input

---
 .../OrderDraftDetailsProducts.tsx                        | 9 ++++-----
 src/storybook/__snapshots__/Stories.test.ts.snap         | 4 ++++
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/orders/components/OrderDraftDetailsProducts/OrderDraftDetailsProducts.tsx b/src/orders/components/OrderDraftDetailsProducts/OrderDraftDetailsProducts.tsx
index 8d8892386..3b73772e9 100644
--- a/src/orders/components/OrderDraftDetailsProducts/OrderDraftDetailsProducts.tsx
+++ b/src/orders/components/OrderDraftDetailsProducts/OrderDraftDetailsProducts.tsx
@@ -15,6 +15,7 @@ import Skeleton from "@saleor/components/Skeleton";
 import TableCellAvatar, {
   AVATAR_MARGIN
 } from "@saleor/components/TableCellAvatar";
+import createNonNegativeValueChangeHandler from "@saleor/utils/handlers/nonNegativeValueChangeHandler";
 import React from "react";
 import { FormattedMessage } from "react-intl";
 
@@ -165,11 +166,9 @@ const OrderDraftDetailsProducts: React.FC<OrderDraftDetailsProductsProps> = prop
                     onSubmit={data => onOrderLineChange(line.id, data)}
                   >
                     {({ change, data, hasChanged, submit }) => {
-                      const handleQuantityChange = event => {
-                        if (/^\d*(\.\d+)?$/.test(event.target.value)) {
-                          change(event);
-                        }
-                      };
+                      const handleQuantityChange = createNonNegativeValueChangeHandler(
+                        change
+                      );
 
                       return (
                         <DebounceForm
diff --git a/src/storybook/__snapshots__/Stories.test.ts.snap b/src/storybook/__snapshots__/Stories.test.ts.snap
index 280992f7a..1797af3a8 100644
--- a/src/storybook/__snapshots__/Stories.test.ts.snap
+++ b/src/storybook/__snapshots__/Stories.test.ts.snap
@@ -108894,6 +108894,7 @@ exports[`Storyshots Views / Orders / Order draft default 1`] = `
                           <input
                             aria-invalid="false"
                             class="MuiInputBase-input-id MuiOutlinedInput-input-id"
+                            min="1"
                             name="quantity"
                             type="number"
                             value="2"
@@ -108998,6 +108999,7 @@ exports[`Storyshots Views / Orders / Order draft default 1`] = `
                           <input
                             aria-invalid="false"
                             class="MuiInputBase-input-id MuiOutlinedInput-input-id"
+                            min="1"
                             name="quantity"
                             type="number"
                             value="2"
@@ -109911,6 +109913,7 @@ exports[`Storyshots Views / Orders / Order draft no user permissions 1`] = `
                           <input
                             aria-invalid="false"
                             class="MuiInputBase-input-id MuiOutlinedInput-input-id"
+                            min="1"
                             name="quantity"
                             type="number"
                             value="2"
@@ -110015,6 +110018,7 @@ exports[`Storyshots Views / Orders / Order draft no user permissions 1`] = `
                           <input
                             aria-invalid="false"
                             class="MuiInputBase-input-id MuiOutlinedInput-input-id"
+                            min="1"
                             name="quantity"
                             type="number"
                             value="2"