From cb3f7d971cda5306046f323e7d9cb561180931e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krzysztof=20=C5=BBuraw?= <9116238+krzysztofzuraw@users.noreply.github.com> Date: Fri, 28 Apr 2023 13:37:24 +0200 Subject: [PATCH] Remove semver logic from navigator & autohide banner (#3584) --- package-lock.json | 17 ++++------------- package.json | 2 -- src/components/Navigator/Navigator.tsx | 5 +---- 3 files changed, 5 insertions(+), 19 deletions(-) diff --git a/package-lock.json b/package-lock.json index c8d4e2c96..6a90c7f5f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -83,7 +83,6 @@ "react-router-dom": "^5.0.1", "react-sortable-hoc": "^1.10.1", "react-sortable-tree": "^2.6.2", - "semver-compare": "^1.0.0", "slugify": "^1.4.6", "tslib": "^2.4.1", "url-join": "^4.0.1", @@ -136,7 +135,6 @@ "@types/react-router-dom": "^4.3.4", "@types/react-sortable-hoc": "^0.7.1", "@types/react-sortable-tree": "^0.3.15", - "@types/semver-compare": "^1.0.1", "@types/url-join": "^4.0.1", "@types/webappsec-credential-management": "^0.5.1", "@typescript-eslint/eslint-plugin": "^5.41.0", @@ -10253,11 +10251,6 @@ "dev": true, "license": "MIT" }, - "node_modules/@types/semver-compare": { - "version": "1.0.1", - "dev": true, - "license": "MIT" - }, "node_modules/@types/setup-polly-jest": { "version": "0.5.1", "license": "MIT", @@ -32519,7 +32512,8 @@ }, "node_modules/semver-compare": { "version": "1.0.0", - "license": "MIT" + "license": "MIT", + "optional": true }, "node_modules/semver-diff": { "version": "3.1.1", @@ -45004,10 +44998,6 @@ "version": "7.3.13", "dev": true }, - "@types/semver-compare": { - "version": "1.0.1", - "dev": true - }, "@types/setup-polly-jest": { "version": "0.5.1", "optional": true, @@ -60222,7 +60212,8 @@ } }, "semver-compare": { - "version": "1.0.0" + "version": "1.0.0", + "optional": true }, "semver-diff": { "version": "3.1.1", diff --git a/package.json b/package.json index 37a8301c1..638b083e6 100644 --- a/package.json +++ b/package.json @@ -90,7 +90,6 @@ "react-router-dom": "^5.0.1", "react-sortable-hoc": "^1.10.1", "react-sortable-tree": "^2.6.2", - "semver-compare": "^1.0.0", "slugify": "^1.4.6", "tslib": "^2.4.1", "url-join": "^4.0.1", @@ -143,7 +142,6 @@ "@types/react-router-dom": "^4.3.4", "@types/react-sortable-hoc": "^0.7.1", "@types/react-sortable-tree": "^0.3.15", - "@types/semver-compare": "^1.0.1", "@types/url-join": "^4.0.1", "@types/webappsec-credential-management": "^0.5.1", "@typescript-eslint/eslint-plugin": "^5.41.0", diff --git a/src/components/Navigator/Navigator.tsx b/src/components/Navigator/Navigator.tsx index 81a1068d7..112fb0610 100644 --- a/src/components/Navigator/Navigator.tsx +++ b/src/components/Navigator/Navigator.tsx @@ -1,4 +1,3 @@ -import { APP_VERSION } from "@dashboard/config"; import useLocalStorage from "@dashboard/hooks/useLocalStorage"; import useNotifier from "@dashboard/hooks/useNotifier"; import { Divider, Fade, Modal, Paper } from "@material-ui/core"; @@ -7,7 +6,6 @@ import Downshift from "downshift"; import hotkeys from "hotkeys-js"; import React from "react"; import { useIntl } from "react-intl"; -import cmp from "semver-compare"; import { getActions, @@ -83,9 +81,8 @@ const Navigator: React.FC = ({ visible, setVisibility }) => { setVisibility(!visible); }); - if (cmp(APP_VERSION, "2.1.0") !== 1 && !notifiedAboutNavigator) { + if (!notifiedAboutNavigator) { notify({ - autohide: null, text: intl.formatMessage( { id: "EM+30g",