djkato/saleor-dashboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #668 from mirumee/fix/menu-testing-context

Browse source 
Add static test id to the menu items
This commit is contained in:
M.Graczyk 2020-08-25 11:51:49 +02:00 committed by GitHub
commit c86206d35f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/components/AppLayout/MenuList.tsx
View file

@ -258,7 +258,8 @@ const MenuList: React.FC<MenuListProps> = props => {
[classes.menuListItemActive]: isAnyChildActive
})}
key={menuItem.label}
data-testid={menuItem.label.toLowerCase()}
data-testid={menuItem.testingContextId}
data-test="menuItemEntry"
>
<div
className={classNames(classes.menuItemHover, {
@ -266,7 +267,6 @@ const MenuList: React.FC<MenuListProps> = props => {
menuItem.ariaLabel === activeSubMenu.label &&
activeSubMenu.isActive
})}
data-test={menuItem.label}
onClick={() => handleSubMenu(menuItem.ariaLabel)}
>
<SVG
@ -313,6 +313,8 @@ const MenuList: React.FC<MenuListProps> = props => {
href={createHref(menuItem.url)}
onClick={event => closeSubMenu(menuItem.url, event)}
key={menuItem.label}
data-testid={menuItem.testingContextId}
data-test="menuItemEntry"
>
<div className={classes.menuItemHover}>
<SVG

21
src/components/AppLayout/menuStructure.ts
View file

@ -24,6 +24,7 @@ export interface IMenuItem {
icon?: any;
label: string;
permission?: PermissionEnum;
testingContextId: string;
url?: string;
}
@ -33,6 +34,7 @@ function createMenuStructure(intl: IntlShape): IMenuItem[] {
ariaLabel: "home",
icon: homeIcon,
label: intl.formatMessage(sectionNames.home),
testingContextId: "home",
url: "/"
},
{
@ -41,22 +43,26 @@ function createMenuStructure(intl: IntlShape): IMenuItem[] {
{
ariaLabel: "products",
label: intl.formatMessage(sectionNames.products),
testingContextId: "products",
url: productListUrl()
},
{
ariaLabel: "categories",
label: intl.formatMessage(sectionNames.categories),
testingContextId: "categories",
url: categoryListUrl()
},
{
ariaLabel: "collections",
label: intl.formatMessage(sectionNames.collections),
testingContextId: "collections",
url: collectionListUrl()
}
],
icon: catalogIcon,
label: intl.formatMessage(commonMessages.catalog),
permission: PermissionEnum.MANAGE_PRODUCTS
permission: PermissionEnum.MANAGE_PRODUCTS,
testingContextId: "catalogue"
},
{
ariaLabel: "orders",
@ -65,24 +71,28 @@ function createMenuStructure(intl: IntlShape): IMenuItem[] {
ariaLabel: "orders",
label: intl.formatMessage(sectionNames.orders),
permission: PermissionEnum.MANAGE_ORDERS,
testingContextId: "orders",
url: orderListUrl()
},
{
ariaLabel: "order drafts",
label: intl.formatMessage(commonMessages.drafts),
permission: PermissionEnum.MANAGE_ORDERS,
testingContextId: "order drafts",
url: orderDraftListUrl()
}
],
icon: ordersIcon,
label: intl.formatMessage(sectionNames.orders),
permission: PermissionEnum.MANAGE_ORDERS
permission: PermissionEnum.MANAGE_ORDERS,
testingContextId: "orders"
},
{
ariaLabel: "customers",
icon: customerIcon,
label: intl.formatMessage(sectionNames.customers),
permission: PermissionEnum.MANAGE_USERS,
testingContextId: "customers",
url: customerListUrl()
},
@ -92,23 +102,27 @@ function createMenuStructure(intl: IntlShape): IMenuItem[] {
{
ariaLabel: "sales",
label: intl.formatMessage(sectionNames.sales),
testingContextId: "sales",
url: saleListUrl()
},
{
ariaLabel: "vouchers",
label: intl.formatMessage(sectionNames.vouchers),
testingContextId: "vouchers",
url: voucherListUrl()
}
],
icon: discountsIcon,
label: intl.formatMessage(commonMessages.discounts),
permission: PermissionEnum.MANAGE_DISCOUNTS
permission: PermissionEnum.MANAGE_DISCOUNTS,
testingContextId: "discounts"
},
{
ariaLabel: "apps",
icon: appsIcon,
label: intl.formatMessage(sectionNames.apps),
permission: PermissionEnum.MANAGE_APPS,
testingContextId: "apps",
url: appsListPath
},
{
@ -116,6 +130,7 @@ function createMenuStructure(intl: IntlShape): IMenuItem[] {
icon: translationIcon,
label: intl.formatMessage(sectionNames.translations),
permission: PermissionEnum.MANAGE_TRANSLATIONS,
testingContextId: "translations",
url: languageListUrl
}
];