djkato/saleor-dashboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Commit review suggestioins

Browse source
This commit is contained in:
dominik-zeglen 2020-07-06 19:04:51 +02:00
parent b1ac074b1e
commit b28bd31aaa
1 changed files with 28 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
src/containers/BackgroundTasks/BackgroundTasksProvider.test.tsx
View file

@ -133,20 +133,22 @@ describe("Background task provider", () => {
it("can queue multiple tasks", done => { it("can queue multiple tasks", done => {
let cycle = 0; let cycle = 0;
const tasks: TaskData[] = [ // Completed in two cycles
{ const shortTask = {
handle: jest.fn(() => handle: jest.fn(() =>
Promise.resolve(cycle > 1 ? TaskStatus.SUCCESS : TaskStatus.PENDING) Promise.resolve(cycle > 1 ? TaskStatus.SUCCESS : TaskStatus.PENDING)
), ),
onCompleted: jest.fn() onCompleted: jest.fn()
}, };
{
handle: jest.fn(() => // Completed in three cycles
Promise.resolve(cycle > 2 ? TaskStatus.SUCCESS : TaskStatus.PENDING) const longTask = {
), handle: jest.fn(() =>
onCompleted: jest.fn() Promise.resolve(cycle > 2 ? TaskStatus.SUCCESS : TaskStatus.PENDING)
} ),
]; onCompleted: jest.fn()
};
const tasks: TaskData[] = [shortTask, longTask];
const { result } = renderBackgroundTasks(); const { result } = renderBackgroundTasks();
@ -157,30 +159,30 @@ describe("Background task provider", () => {
jest.advanceTimersByTime(backgroundTasksRefreshTime + 100); jest.advanceTimersByTime(backgroundTasksRefreshTime + 100);
setImmediate(() => { setImmediate(() => {
expect(tasks[0].handle).toHaveBeenCalledTimes(1); expect(shortTask.handle).toHaveBeenCalledTimes(1);
expect(tasks[1].handle).toHaveBeenCalledTimes(1); expect(longTask.handle).toHaveBeenCalledTimes(1);
expect(tasks[0].onCompleted).toHaveBeenCalledTimes(0); expect(shortTask.onCompleted).toHaveBeenCalledTimes(0);
expect(tasks[1].onCompleted).toHaveBeenCalledTimes(0); expect(longTask.onCompleted).toHaveBeenCalledTimes(0);
// Set time to backgroundTasksRefreshTime * 2 // Set time to backgroundTasksRefreshTime * 2
cycle += 1; cycle += 1;
jest.advanceTimersByTime(backgroundTasksRefreshTime); jest.advanceTimersByTime(backgroundTasksRefreshTime);
setImmediate(() => { setImmediate(() => {
expect(tasks[0].handle).toHaveBeenCalledTimes(2); expect(shortTask.handle).toHaveBeenCalledTimes(2);
expect(tasks[1].handle).toHaveBeenCalledTimes(2); expect(longTask.handle).toHaveBeenCalledTimes(2);
expect(tasks[0].onCompleted).toHaveBeenCalledTimes(1); expect(shortTask.onCompleted).toHaveBeenCalledTimes(1);
expect(tasks[1].onCompleted).toHaveBeenCalledTimes(0); expect(longTask.onCompleted).toHaveBeenCalledTimes(0);
// Set time to backgroundTasksRefreshTime * 3 // Set time to backgroundTasksRefreshTime * 3
cycle += 1; cycle += 1;
jest.advanceTimersByTime(backgroundTasksRefreshTime); jest.advanceTimersByTime(backgroundTasksRefreshTime);
setImmediate(() => { setImmediate(() => {
expect(tasks[0].handle).toHaveBeenCalledTimes(2); expect(shortTask.handle).toHaveBeenCalledTimes(2);
expect(tasks[1].handle).toHaveBeenCalledTimes(3); expect(longTask.handle).toHaveBeenCalledTimes(3);
expect(tasks[0].onCompleted).toHaveBeenCalledTimes(1); expect(shortTask.onCompleted).toHaveBeenCalledTimes(1);
expect(tasks[1].onCompleted).toHaveBeenCalledTimes(1); expect(longTask.onCompleted).toHaveBeenCalledTimes(1);
done(); done();
}); });