diff --git a/.changeset/yellow-impalas-lie.md b/.changeset/yellow-impalas-lie.md new file mode 100644 index 000000000..63413d275 --- /dev/null +++ b/.changeset/yellow-impalas-lie.md @@ -0,0 +1,5 @@ +--- +"saleor-dashboard": minor +--- + +Apps: Fixed problem with Permissions Modal that was clipped on smaller screens. Now long permissions list is scrollable. diff --git a/src/apps/components/AppPermissionsDialog/AppPermissionsDialogConfirmation.tsx b/src/apps/components/AppPermissionsDialog/AppPermissionsDialogConfirmation.tsx index d37f52050..b97bca709 100644 --- a/src/apps/components/AppPermissionsDialog/AppPermissionsDialogConfirmation.tsx +++ b/src/apps/components/AppPermissionsDialog/AppPermissionsDialogConfirmation.tsx @@ -27,7 +27,7 @@ export const AppPermissionsDialogConfirmation = ({ const { mapCodesToNames } = useGetAvailableAppPermissions(); return ( - + {intl.formatMessage(messages.summaryText)} diff --git a/src/apps/components/AppPermissionsDialog/AppPermissionsDialogPermissionPicker.tsx b/src/apps/components/AppPermissionsDialog/AppPermissionsDialogPermissionPicker.tsx index 048608e85..0265569b2 100644 --- a/src/apps/components/AppPermissionsDialog/AppPermissionsDialogPermissionPicker.tsx +++ b/src/apps/components/AppPermissionsDialog/AppPermissionsDialogPermissionPicker.tsx @@ -15,6 +15,12 @@ interface AppPermissionsDialogPermissionPickerProps { onClose(): void; } +/** + * Approximate height that clips list and makes it scrollable. + * This makes it avaialble on small devices, including horizontal ipad air + */ +const LIST_MAX_HEIGHT = "50vh"; + export const AppPermissionsDialogPermissionPicker = ({ onSubmit, onChange, @@ -39,35 +45,37 @@ export const AppPermissionsDialogPermissionPicker = ({ onChange(values); }} > - - {allPermissions.map(perm => { - const isAssigned = Boolean(selected.find(p => p === perm.code)); + + + {allPermissions.map(perm => { + const isAssigned = Boolean(selected.find(p => p === perm.code)); - return ( - - - - {perm.name} - - - ); - })} - - + return ( + + + + {perm.name} + + + ); + })} + + +