Improve descriptions

This commit is contained in:
dominik-zeglen 2019-08-20 11:17:06 +02:00
parent a1506b7df1
commit ad43229a20
2 changed files with 10 additions and 14 deletions

View file

@ -34,7 +34,7 @@ const AttributeDetails: React.FC<AttributeDetailsProps> = ({
{ {
label: intl.formatMessage({ label: intl.formatMessage({
defaultMessage: "Dropdown", defaultMessage: "Dropdown",
description: "attribute editor component type", description: "product attribute type",
id: "attributeDetailsInputTypeDropdown" id: "attributeDetailsInputTypeDropdown"
}), }),
value: AttributeInputTypeEnum.DROPDOWN value: AttributeInputTypeEnum.DROPDOWN
@ -42,7 +42,7 @@ const AttributeDetails: React.FC<AttributeDetailsProps> = ({
{ {
label: intl.formatMessage({ label: intl.formatMessage({
defaultMessage: "Multiple Select", defaultMessage: "Multiple Select",
description: "attribute editor component type", description: "product attribute type",
id: "attributeDetailsInputTypeMultiselect" id: "attributeDetailsInputTypeMultiselect"
}), }),
value: AttributeInputTypeEnum.MULTISELECT value: AttributeInputTypeEnum.MULTISELECT
@ -52,9 +52,7 @@ const AttributeDetails: React.FC<AttributeDetailsProps> = ({
return ( return (
<Card> <Card>
<CardTitle <CardTitle
title={ title={intl.formatMessage(commonMessages.generalInformations)}
intl.formatMessage(commonMessages.generalInformations)
}
/> />
<CardContent> <CardContent>
<TextField <TextField
@ -62,7 +60,7 @@ const AttributeDetails: React.FC<AttributeDetailsProps> = ({
error={!!errors.name} error={!!errors.name}
label={intl.formatMessage({ label={intl.formatMessage({
defaultMessage: "Default Label", defaultMessage: "Default Label",
description: "attribute label input field", description: "attribute's label",
id: "attributeDetailsNameInputLabel" id: "attributeDetailsNameInputLabel"
})} })}
name={"name" as keyof AttributePageFormData} name={"name" as keyof AttributePageFormData}
@ -77,7 +75,7 @@ const AttributeDetails: React.FC<AttributeDetailsProps> = ({
error={!!errors.slug} error={!!errors.slug}
label={intl.formatMessage({ label={intl.formatMessage({
defaultMessage: "Attribute Code", defaultMessage: "Attribute Code",
description: "attribute slug input field", description: "attribute's slug short code label",
id: "attributeDetailsSlugInputLabel" id: "attributeDetailsSlugInputLabel"
})} })}
name={"slug" as keyof AttributePageFormData} name={"slug" as keyof AttributePageFormData}
@ -103,7 +101,7 @@ const AttributeDetails: React.FC<AttributeDetailsProps> = ({
hint={errors.inputType} hint={errors.inputType}
label={intl.formatMessage({ label={intl.formatMessage({
defaultMessage: "Catalog Input type for Store Owner", defaultMessage: "Catalog Input type for Store Owner",
description: "attribute editor component type select field label", description: "attribute's editor component",
id: "attributeDetailsInputTypeField" id: "attributeDetailsInputTypeField"
})} })}
name="inputType" name="inputType"

View file

@ -85,35 +85,34 @@ const AttributeList: React.StatelessComponent<AttributeListProps> = ({
<TableCell className={classes.colSlug}> <TableCell className={classes.colSlug}>
<FormattedMessage <FormattedMessage
defaultMessage="Attribute Code" defaultMessage="Attribute Code"
description="attribute list: slug column header"
id="attributeListSlugColumnHeader" id="attributeListSlugColumnHeader"
/> />
</TableCell> </TableCell>
<TableCell className={classes.colName}> <TableCell className={classes.colName}>
<FormattedMessage <FormattedMessage
defaultMessage="Default Label" defaultMessage="Default Label"
description="attribute list: name column header" description="attribute's label'"
id="attributeListNameColumnHeader" id="attributeListNameColumnHeader"
/> />
</TableCell> </TableCell>
<TableCell className={classes.colVisible}> <TableCell className={classes.colVisible}>
<FormattedMessage <FormattedMessage
defaultMessage="Visible" defaultMessage="Visible"
description="attribute list: visibility column header" description="attribute is visible"
id="attributeListVisibilityColumnHeader" id="attributeListVisibilityColumnHeader"
/> />
</TableCell> </TableCell>
<TableCell className={classes.colSearchable}> <TableCell className={classes.colSearchable}>
<FormattedMessage <FormattedMessage
defaultMessage="Searchable" defaultMessage="Searchable"
description="attribute list: attribute can be searched in dashboard column header" description="attribute can be searched in dashboard"
id="attributeListSearchableColumnHeader" id="attributeListSearchableColumnHeader"
/> />
</TableCell> </TableCell>
<TableCell className={classes.colFaceted}> <TableCell className={classes.colFaceted}>
<FormattedMessage <FormattedMessage
defaultMessage="Use in faceted search" defaultMessage="Use in faceted search"
description="attribute list: attribute can be searched in storefront column header" description="attribute can be searched in storefront"
id="attributeListFacetedColumnHeader" id="attributeListFacetedColumnHeader"
/> />
</TableCell> </TableCell>
@ -188,7 +187,6 @@ const AttributeList: React.StatelessComponent<AttributeListProps> = ({
<TableCell colSpan={numberOfColumns}> <TableCell colSpan={numberOfColumns}>
<FormattedMessage <FormattedMessage
defaultMessage="No attributes found" defaultMessage="No attributes found"
description="no attributes found with present filters"
id="AttributeListNoAttributes" id="AttributeListNoAttributes"
/> />
</TableCell> </TableCell>