Improve code readability

This commit is contained in:
dominik-zeglen 2020-04-02 11:52:15 +02:00
parent 85b730bce8
commit a436b13372

View file

@ -105,7 +105,7 @@ const ProductVariantCreatePage: React.FC<ProductVariantCreatePageProps> = props
const { attributes, defaultPrice, errors, onSubmit, ...contentProps } = props; const { attributes, defaultPrice, errors, onSubmit, ...contentProps } = props;
const classes = useStyles(props); const classes = useStyles(props);
const intl = useIntl(); const intl = useIntl();
const [step, { next, prev, set: setStep }] = useWizard< const [step, { next: nextStep, prev: prevStep, set: setStep }] = useWizard<
ProductVariantCreatorStep ProductVariantCreatorStep
>(ProductVariantCreatorStep.values, [ >(ProductVariantCreatorStep.values, [
ProductVariantCreatorStep.values, ProductVariantCreatorStep.values,
@ -113,7 +113,7 @@ const ProductVariantCreatePage: React.FC<ProductVariantCreatePageProps> = props
ProductVariantCreatorStep.summary ProductVariantCreatorStep.summary
]); ]);
const [data, dispatchFormDataAction] = React.useReducer( const [wizardData, dispatchFormDataAction] = React.useReducer(
reduceProductVariantCreateFormData, reduceProductVariantCreateFormData,
createInitialForm(attributes, defaultPrice) createInitialForm(attributes, defaultPrice)
); );
@ -131,7 +131,7 @@ const ProductVariantCreatePage: React.FC<ProductVariantCreatePageProps> = props
<ProductVariantCreateTabs step={step} onStepClick={setStep} /> <ProductVariantCreateTabs step={step} onStepClick={setStep} />
<PageHeader title={getTitle(step, intl)}> <PageHeader title={getTitle(step, intl)}>
{step !== ProductVariantCreatorStep.values && ( {step !== ProductVariantCreatorStep.values && (
<Button className={classes.button} color="primary" onClick={prev}> <Button className={classes.button} color="primary" onClick={prevStep}>
<FormattedMessage <FormattedMessage
defaultMessage="Previous" defaultMessage="Previous"
description="previous step, button" description="previous step, button"
@ -142,9 +142,9 @@ const ProductVariantCreatePage: React.FC<ProductVariantCreatePageProps> = props
<Button <Button
className={classes.button} className={classes.button}
color="primary" color="primary"
disabled={!canHitNext(step, data)} disabled={!canHitNext(step, wizardData)}
variant="contained" variant="contained"
onClick={next} onClick={nextStep}
> >
<FormattedMessage defaultMessage="Next" description="button" /> <FormattedMessage defaultMessage="Next" description="button" />
</Button> </Button>
@ -152,9 +152,9 @@ const ProductVariantCreatePage: React.FC<ProductVariantCreatePageProps> = props
<Button <Button
className={classes.button} className={classes.button}
color="primary" color="primary"
disabled={!canHitNext(step, data)} disabled={!canHitNext(step, wizardData)}
variant="contained" variant="contained"
onClick={() => onSubmit(data.variants)} onClick={() => onSubmit(wizardData.variants)}
> >
<FormattedMessage <FormattedMessage
defaultMessage="Create" defaultMessage="Create"
@ -166,7 +166,7 @@ const ProductVariantCreatePage: React.FC<ProductVariantCreatePageProps> = props
<ProductVariantCreatorContent <ProductVariantCreatorContent
{...contentProps} {...contentProps}
attributes={attributes} attributes={attributes}
data={data} data={wizardData}
dispatchFormDataAction={dispatchFormDataAction} dispatchFormDataAction={dispatchFormDataAction}
errors={errors} errors={errors}
step={step} step={step}