djkato/saleor-dashboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1171 from mirumee/SALEOR-2255/fix-unnecessary-mutations-on-meta-update

Browse source 
reset metadataChanged state after submitting form
This commit is contained in:
SektorDV 2021-06-18 11:14:22 +02:00 committed by GitHub
commit a114a39f45
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/orders/components/OrderDetailsPage/OrderDetailsPage.tsx
View file

@ -138,7 +138,8 @@ const OrderDetailsPage: React.FC<OrderDetailsPageProps> = props => {
const { const {
isMetadataModified, isMetadataModified,
isPrivateMetadataModified, isPrivateMetadataModified,
makeChangeHandler: makeMetadataChangeHandler makeChangeHandler: makeMetadataChangeHandler,
resetMetadataChanged
} = useMetadataChangeTrigger(); } = useMetadataChangeTrigger();
const isOrderUnconfirmed = order?.status === OrderStatus.UNCONFIRMED; const isOrderUnconfirmed = order?.status === OrderStatus.UNCONFIRMED;
@ -149,16 +150,18 @@ const OrderDetailsPage: React.FC<OrderDetailsPageProps> = props => {
line => line.quantityFulfilled < line.quantity line => line.quantityFulfilled < line.quantity
); );
const handleSubmit = (data: MetadataFormData) => { const handleSubmit = async (data: MetadataFormData) => {
const metadata = isMetadataModified ? data.metadata : undefined; const metadata = isMetadataModified ? data.metadata : undefined;
const privateMetadata = isPrivateMetadataModified const privateMetadata = isPrivateMetadataModified
? data.privateMetadata ? data.privateMetadata
: undefined; : undefined;
return onSubmit({ const result = await onSubmit({
metadata, metadata,
privateMetadata privateMetadata
}); });
resetMetadataChanged();
return result;
}; };
const initial: MetadataFormData = { const initial: MetadataFormData = {

8
src/utils/metadata/useMetadataChangeTrigger.ts
View file

@ -18,10 +18,16 @@ function useMetadataChangeTrigger() {
onChange(event); onChange(event);
}; };
const resetMetadataChanged = () => {
setMetadataModified(false);
setPrivateMetadataModified(false);
};
return { return {
isMetadataModified, isMetadataModified,
isPrivateMetadataModified, isPrivateMetadataModified,
makeChangeHandler makeChangeHandler,
resetMetadataChanged
}; };
} }