djkato/saleor-dashboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix broken pagination in swatch attributes (#2282)

Browse source 
* Fix broken pagination in swatch attributes

* Do not apply styling when value is undefined

* Extract logic to function
This commit is contained in:
Michał Droń 2022-09-21 17:35:04 +02:00 committed by GitHub
parent 5dbd6fed8a
commit 88a0db22e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/attributes/components/AttributeValues/AttributeValues.tsx
View file

@ -16,6 +16,7 @@ import {
import TablePagination from "@saleor/components/TablePagination";
import {
AttributeInputTypeEnum,
AttributeValueFragment,
AttributeValueListFragment,
} from "@saleor/graphql";
import { DeleteIcon, IconButton, makeStyles } from "@saleor/macaw-ui";
@ -75,6 +76,15 @@ const useStyles = makeStyles(
{ name: "AttributeValues" },
);
const getSwatchCellStyle = (value: AttributeValueFragment) => {
if (!value) {
return;
}
return value.file
? { backgroundImage: `url(${value.file.url})` }
: { backgroundColor: value.value };
};
const AttributeValues: React.FC<AttributeValuesProps> = ({
disabled,
onValueAdd,
@ -179,11 +189,7 @@ const AttributeValues: React.FC<AttributeValuesProps> = ({
<div
data-test-id="swatch-image"
className={classes.swatch}
style={
value?.file
? { backgroundImage: `url(${value.file.url})` }
: { backgroundColor: value.value }
}
style={getSwatchCellStyle(value)}
/>
</TableCell>
)}