Fix update metadata in Attribute details (#3784)

* Fix update metadata

* Restore use makeMetadataChangeHandler
This commit is contained in:
Paweł Chyła 2023-06-26 10:05:25 +02:00 committed by GitHub
parent 02c27b898f
commit 85c8f15605
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -96,11 +96,8 @@ const AttributePage: React.FC<AttributePageProps> = ({
const intl = useIntl(); const intl = useIntl();
const navigate = useNavigator(); const navigate = useNavigator();
const { const { makeChangeHandler: makeMetadataChangeHandler } =
isMetadataModified, useMetadataChangeTrigger();
isPrivateMetadataModified,
makeChangeHandler: makeMetadataChangeHandler,
} = useMetadataChangeTrigger();
const initialForm: AttributePageFormData = !attribute const initialForm: AttributePageFormData = !attribute
? { ? {
@ -137,15 +134,10 @@ const AttributePage: React.FC<AttributePageProps> = ({
}; };
const handleSubmit = (data: AttributePageFormData) => { const handleSubmit = (data: AttributePageFormData) => {
const metadata = !attribute || isMetadataModified ? data.metadata : [];
const type = attribute === null ? data.type : undefined; const type = attribute === null ? data.type : undefined;
const privateMetadata =
!attribute || isPrivateMetadataModified ? data.privateMetadata : [];
return onSubmit({ return onSubmit({
...data, ...data,
metadata,
privateMetadata,
slug: data.slug || slugify(data.name).toLowerCase(), slug: data.slug || slugify(data.name).toLowerCase(),
type, type,
}); });
@ -219,7 +211,11 @@ const AttributePage: React.FC<AttributePageProps> = ({
</> </>
)} )}
<CardSpacer /> <CardSpacer />
<Metadata data={data} onChange={changeMetadata} /> <Metadata
data={data}
isLoading={disabled}
onChange={changeMetadata}
/>
</DetailPageLayout.Content> </DetailPageLayout.Content>
<DetailPageLayout.RightSidebar> <DetailPageLayout.RightSidebar>
<AttributeOrganization <AttributeOrganization