diff --git a/CHANGELOG.md b/CHANGELOG.md index e6e7a757a..b51f868c4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -73,6 +73,8 @@ All notable, unreleased changes to this project will be documented in this file. - Add Metadata for Sale & Voucher - #7653 by @piotrgrundas - Add variant create options dialog - #1238 by @orzechdev - Fix for errors on changing channel availability - #1264 by @krzysztofwolski +- Fixed navigation menu items reordering issue - #1239 by @kamilpastuszka +- Fixed issue with modals containing invalid, redundant scrolls #1240 by @kamilpastuszka - Add text attribute for product and page translations - #1276 by @kamilpastuszka # 2.11.1 diff --git a/src/channels/components/ChannelsWithVariantsAvailabilityDialog/ChannelsWithVariantsAvailabilityDialogContent.tsx b/src/channels/components/ChannelsWithVariantsAvailabilityDialog/ChannelsWithVariantsAvailabilityDialogContent.tsx index 6cea5b7c9..dfe385339 100644 --- a/src/channels/components/ChannelsWithVariantsAvailabilityDialog/ChannelsWithVariantsAvailabilityDialogContent.tsx +++ b/src/channels/components/ChannelsWithVariantsAvailabilityDialog/ChannelsWithVariantsAvailabilityDialogContent.tsx @@ -75,7 +75,8 @@ const useSummaryStyles = makeStyles( height: theme.spacing(10), padding: 0, margin: 0, - minHeight: 0 + minHeight: 0, + paddingRight: theme.spacing(2.5) }, content: { margin: 0 diff --git a/src/components/AssignAttributeDialog/AssignAttributeDialog.tsx b/src/components/AssignAttributeDialog/AssignAttributeDialog.tsx index b03ceccfb..e5e19af90 100644 --- a/src/components/AssignAttributeDialog/AssignAttributeDialog.tsx +++ b/src/components/AssignAttributeDialog/AssignAttributeDialog.tsx @@ -50,8 +50,15 @@ const useStyles = makeStyles( height: theme.spacing(3), justifyContent: "center" }, + searchArea: { + marginBottom: theme.spacing(3), + overflowY: "hidden", + paddingBottom: theme.spacing(6) + }, scrollArea: { - overflowY: "scroll" + overflowY: "scroll", + paddingTop: 0, + marginBottom: theme.spacing(3) }, wideCell: { width: "100%" @@ -110,7 +117,7 @@ const AssignAttributeDialog: React.FC = ({ description="dialog header" /> - + = />
- + + + + {filter(countries, data.query, { diff --git a/src/orders/components/OrderProductAddDialog/OrderProductAddDialog.tsx b/src/orders/components/OrderProductAddDialog/OrderProductAddDialog.tsx index b48da3b3a..b6b02a977 100644 --- a/src/orders/components/OrderProductAddDialog/OrderProductAddDialog.tsx +++ b/src/orders/components/OrderProductAddDialog/OrderProductAddDialog.tsx @@ -50,7 +50,9 @@ const useStyles = makeStyles( padding: 0 }, content: { - overflowY: "scroll" + overflowY: "scroll", + paddingTop: 0, + marginBottom: theme.spacing(3) }, grayText: { color: theme.palette.text.disabled @@ -63,7 +65,12 @@ const useStyles = makeStyles( marginTop: theme.spacing(3) }, overflow: { - overflowY: "visible" + overflowY: "hidden" + }, + topArea: { + overflowY: "hidden", + paddingBottom: theme.spacing(6), + margin: theme.spacing(0, 3, 3, 3) }, productCheckboxCell: { "&:first-child": { @@ -250,7 +257,7 @@ const OrderProductAddDialog: React.FC = props => { description="dialog header" /> - + + + + {filter(countries, data.query, { diff --git a/src/styles/useScrollableDialogStyle.ts b/src/styles/useScrollableDialogStyle.ts index f047d48e4..5749b554f 100644 --- a/src/styles/useScrollableDialogStyle.ts +++ b/src/styles/useScrollableDialogStyle.ts @@ -14,12 +14,14 @@ const useScrollableDialogStyle = makeStyles( marginTop: theme.spacing(3) }, topArea: { - overflowY: "visible" + overflowY: "hidden", + marginBottom: theme.spacing(3) }, scrollArea: { overflowY: "scroll", paddingTop: 0, - height: "inherit" + height: "inherit", + marginBottom: theme.spacing(3) } }), {