djkato/saleor-dashboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Variant Details console errors (#742)

Browse source 
* Add default empty unit when there is no specified one

* Add index required in draggable tables

* Select fields should get undefined value instead of null
This commit is contained in:
Krzysztof Wolski 2020-10-02 11:04:54 +02:00 committed by GitHub
parent 287a2eb8ed
commit 7e95d53155
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/products/components/ProductShipping/ProductShipping.tsx
View file

@ -49,7 +49,9 @@ const ProductShipping: React.FC<ProductShippingProps> = props => {
onChange={onChange} onChange={onChange}
InputProps={{ InputProps={{
endAdornment: ( endAdornment: (
<InputAdornment position="end">{weightUnit}</InputAdornment> <InputAdornment position="end">
{weightUnit || ""}
</InputAdornment>
), ),
inputProps: { inputProps: {
min: 0 min: 0

2
src/products/components/ProductVariantAttributes/ProductVariantAttributes.tsx
View file

@ -52,7 +52,7 @@ function getAttributeValue(
attributes: VariantAttributeInput[] attributes: VariantAttributeInput[]
): string { ): string {
const attribute = attributes.find(attr => attr.id === id); const attribute = attributes.find(attr => attr.id === id);
return attribute.value; return attribute?.value === null ? undefined : attribute.value;
} }
function getAttributeValueChoices( function getAttributeValueChoices(

2
src/products/components/ProductVariantNavigation/ProductVariantNavigation.tsx
View file

@ -90,7 +90,7 @@ const ProductVariantNavigation: React.FC<ProductVariantNavigationProps> = props
<SortableTableRow <SortableTableRow
hover={!!variant} hover={!!variant}
key={variant ? variant.id : "skeleton"} key={variant ? variant.id : "skeleton"}
index={variantIndex} index={variantIndex || 0}
className={classNames(classes.link, { className={classNames(classes.link, {
[classes.tabActive]: variant && variant.id === current [classes.tabActive]: variant && variant.id === current
})} })}