From 78077f8220edc10053b14544320994398cb4feff Mon Sep 17 00:00:00 2001 From: Timur Carpeev Date: Tue, 23 May 2023 10:35:16 +0200 Subject: [PATCH] Remove misleading helperText on SEO form (#3677) --- locale/defaultMessages.json | 3 --- src/components/SeoForm/SeoForm.tsx | 16 +--------------- 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/locale/defaultMessages.json b/locale/defaultMessages.json index ea64179b8..f2366307b 100644 --- a/locale/defaultMessages.json +++ b/locale/defaultMessages.json @@ -7589,9 +7589,6 @@ "context": "set expiry date selected label", "string": "Set gift card expiry date" }, - "s/sTT6": { - "string": "If empty, the preview shows what will be autogenerated." - }, "s17U7u": { "context": "discount type", "string": "Percentage" diff --git a/src/components/SeoForm/SeoForm.tsx b/src/components/SeoForm/SeoForm.tsx index 314d0a3a7..48c8985f2 100644 --- a/src/components/SeoForm/SeoForm.tsx +++ b/src/components/SeoForm/SeoForm.tsx @@ -9,7 +9,7 @@ import { TextField } from "@material-ui/core"; import { makeStyles } from "@saleor/macaw-ui"; import { Box, Button, Input, Text } from "@saleor/macaw-ui/next"; import React from "react"; -import { defineMessages, FormattedMessage, useIntl } from "react-intl"; +import { FormattedMessage, useIntl } from "react-intl"; import { DashboardCard } from "../Card"; @@ -64,7 +64,6 @@ export const SeoForm: React.FC = props => { disabled, errors = [], helperText, - allowEmptySlug = false, loading, title, slug, @@ -82,20 +81,9 @@ export const SeoForm: React.FC = props => { const shouldDisplayHelperText = helperText && !expanded; - const { seoFieldMessage } = defineMessages({ - seoFieldMessage: { - id: "s/sTT6", - defaultMessage: "If empty, the preview shows what will be autogenerated.", - }, - }); - const getSlugHelperMessage = () => { const error = !!getError(SeoField.slug); - if (allowEmptySlug && !error) { - return intl.formatMessage(seoFieldMessage); - } - return error ? getSlugErrorMessage() : ""; }; @@ -185,7 +173,6 @@ export const SeoForm: React.FC = props => { onChange={onChange} maxLength={maxTitleLength} placeholder={titlePlaceholder} - helperText={intl.formatMessage(seoFieldMessage)} label={ @@ -235,7 +222,6 @@ export const SeoForm: React.FC = props => { )} } - helperText={intl.formatMessage(seoFieldMessage)} InputProps={{ inputProps: { maxLength: maxDescriptionLength,