From 759be70ede649937368e1a835867224e5c04a8a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20Szyma=C5=84ski?= Date: Thu, 6 Feb 2020 10:30:58 +0100 Subject: [PATCH 1/3] Add dockerfile for development purposes --- Dockerfile.dev | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 Dockerfile.dev diff --git a/Dockerfile.dev b/Dockerfile.dev new file mode 100644 index 000000000..0e38180d1 --- /dev/null +++ b/Dockerfile.dev @@ -0,0 +1,16 @@ +FROM node:10 + +WORKDIR /app +COPY package*.json ./ +RUN npm install +COPY . . +ARG APP_MOUNT_URI +ARG API_URI +ARG STATIC_URL +ENV API_URI http://localhost:8000/graphql/ +ENV APP_MOUNT_URI /dashboard/ +ENV STATIC_URL /dashboard/ +VOLUME /app + +EXPOSE 9000 +CMD npm start -- --host 0.0.0.0 From 981901af39e6f442878c74f68c64ebb42c619202 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20Szyma=C5=84ski?= Date: Fri, 7 Feb 2020 10:03:26 +0100 Subject: [PATCH 2/3] Remove volume from dev dockerfile --- Dockerfile.dev | 1 - 1 file changed, 1 deletion(-) diff --git a/Dockerfile.dev b/Dockerfile.dev index 0e38180d1..13567f16c 100644 --- a/Dockerfile.dev +++ b/Dockerfile.dev @@ -10,7 +10,6 @@ ARG STATIC_URL ENV API_URI http://localhost:8000/graphql/ ENV APP_MOUNT_URI /dashboard/ ENV STATIC_URL /dashboard/ -VOLUME /app EXPOSE 9000 CMD npm start -- --host 0.0.0.0 From 88e0df817a49439f7c95db45576e09a0cd3a3b70 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20Szyma=C5=84ski?= Date: Fri, 7 Feb 2020 10:44:20 +0100 Subject: [PATCH 3/3] Better env vars handling --- Dockerfile.dev | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Dockerfile.dev b/Dockerfile.dev index 13567f16c..9ac570133 100644 --- a/Dockerfile.dev +++ b/Dockerfile.dev @@ -7,9 +7,9 @@ COPY . . ARG APP_MOUNT_URI ARG API_URI ARG STATIC_URL -ENV API_URI http://localhost:8000/graphql/ -ENV APP_MOUNT_URI /dashboard/ -ENV STATIC_URL /dashboard/ +ENV API_URI ${API_URI:-http://localhost:8000/graphql/} +ENV APP_MOUNT_URI ${APP_MOUNT_URI:-/dashboard/} +ENV STATIC_URL ${STATIC_URL:-/dashboard/} EXPOSE 9000 CMD npm start -- --host 0.0.0.0