From 5adcc77e1483c6c3489915ec484f1e4a6879dcce Mon Sep 17 00:00:00 2001
From: Dawid Tarasiuk <tarasiukdawid@gmail.com>
Date: Fri, 2 Oct 2020 12:36:41 +0200
Subject: [PATCH 1/2] Fix style of product type attributes empty table

---
 .../ProductTypeAttributes.tsx                 | 42 ++++++++++---------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/src/productTypes/components/ProductTypeAttributes/ProductTypeAttributes.tsx b/src/productTypes/components/ProductTypeAttributes/ProductTypeAttributes.tsx
index defe87b39..dfd6d57d3 100644
--- a/src/productTypes/components/ProductTypeAttributes/ProductTypeAttributes.tsx
+++ b/src/productTypes/components/ProductTypeAttributes/ProductTypeAttributes.tsx
@@ -125,26 +125,28 @@ const ProductTypeAttributes: React.FC<ProductTypeAttributesProps> = props => {
           <col className={classes.colSlug} />
           <col className={classes.colAction} />
         </colgroup>
-        <TableHead
-          colSpan={numberOfColumns}
-          disabled={disabled}
-          dragRows
-          selected={selected}
-          items={attributes}
-          toggleAll={toggleAll}
-          toolbar={toolbar}
-        >
-          <TableCell className={classes.colName}>
-            <FormattedMessage defaultMessage="Attribute name" />
-          </TableCell>
-          <TableCell className={classes.colName}>
-            <FormattedMessage
-              defaultMessage="Slug"
-              description="attribute internal name"
-            />
-          </TableCell>
-          <TableCell />
-        </TableHead>
+        {attributes?.length > 0 && (
+          <TableHead
+            colSpan={numberOfColumns}
+            disabled={disabled}
+            dragRows
+            selected={selected}
+            items={attributes}
+            toggleAll={toggleAll}
+            toolbar={toolbar}
+          >
+            <TableCell className={classes.colName}>
+              <FormattedMessage defaultMessage="Attribute name" />
+            </TableCell>
+            <TableCell className={classes.colName}>
+              <FormattedMessage
+                defaultMessage="Slug"
+                description="attribute internal name"
+              />
+            </TableCell>
+            <TableCell />
+          </TableHead>
+        )}
         <SortableTableBody onSortEnd={onAttributeReorder}>
           {renderCollection(
             attributes,

From 8dcb263cd3ef3323dd34805133f1c2b29d28308a Mon Sep 17 00:00:00 2001
From: Dawid Tarasiuk <tarasiukdawid@gmail.com>
Date: Fri, 2 Oct 2020 12:50:58 +0200
Subject: [PATCH 2/2] Update product type test snapshot

---
 CHANGELOG.md                                  |  2 +-
 .../__snapshots__/Stories.test.ts.snap        | 89 -------------------
 2 files changed, 1 insertion(+), 90 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f4e55add7..e19c7f11f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -47,7 +47,7 @@ All notable, unreleased changes to this project will be documented in this file.
 - Change plural form of "informations" to "information" strings across the app #722 by @mmarkusik
 - Fix misaligned rich text draft controls - #725 by @orzechdev
 - Allow taxes to be configured per product - #728 by @dominik-zeglen
-
+- Fix style of product type attributes empty table - #744 by @orzechdev
 
 ## 2.10.1
 
diff --git a/src/storybook/__snapshots__/Stories.test.ts.snap b/src/storybook/__snapshots__/Stories.test.ts.snap
index a28871efb..71cac422c 100644
--- a/src/storybook/__snapshots__/Stories.test.ts.snap
+++ b/src/storybook/__snapshots__/Stories.test.ts.snap
@@ -128346,71 +128346,6 @@ exports[`Storyshots Views / Product types / Product type details loading 1`] = `
                     class="ProductTypeAttributes-colAction-id"
                   />
                 </colgroup>
-                <thead
-                  class="MuiTableHead-root-id"
-                >
-                  <tr
-                    class="MuiTableRow-root-id MuiTableRow-head-id"
-                  >
-                    <th
-                      class="MuiTableCell-root-id MuiTableCell-head-id"
-                      scope="col"
-                    />
-                    <th
-                      class="MuiTableCell-root-id MuiTableCell-head-id TableHead-dragRows-id MuiTableCell-paddingCheckbox-id"
-                      scope="col"
-                    >
-                      <span
-                        aria-disabled="true"
-                        class="MuiButtonBase-root-id MuiIconButton-root-id PrivateSwitchBase-root-id MuiCheckbox-root-id MuiCheckbox-colorPrimary-id PrivateSwitchBase-disabled-id MuiCheckbox-disabled-id MuiIconButton-colorPrimary-id MuiIconButton-disabled-id MuiButtonBase-disabled-id"
-                        tabindex="-1"
-                      >
-                        <span
-                          class="MuiIconButton-label-id"
-                        >
-                          <input
-                            class="PrivateSwitchBase-input-id"
-                            data-indeterminate="false"
-                            disabled=""
-                            type="checkbox"
-                          />
-                          <svg
-                            aria-hidden="true"
-                            class="MuiSvgIcon-root-id"
-                            focusable="false"
-                            role="presentation"
-                            viewBox="0 0 24 24"
-                          >
-                            <rect
-                              fill="none"
-                              height="14"
-                              stroke="currentColor"
-                              width="14"
-                              x="5"
-                              y="5"
-                            />
-                          </svg>
-                        </span>
-                      </span>
-                    </th>
-                    <th
-                      class="MuiTableCell-root-id MuiTableCell-head-id ProductTypeAttributes-colName-id"
-                      scope="col"
-                    >
-                      Attribute name
-                    </th>
-                    <th
-                      class="MuiTableCell-root-id MuiTableCell-head-id ProductTypeAttributes-colName-id"
-                      scope="col"
-                    >
-                      Slug
-                    </th>
-                    <th
-                      class="MuiTableCell-root-id MuiTableCell-head-id"
-                      scope="col"
-                    />
-                  </tr>
-                </thead>
                 <tbody
                   class="MuiTableBody-root-id"
                 >
@@ -128972,30 +128907,6 @@ exports[`Storyshots Views / Product types / Product type details no attributes 1
                     class="ProductTypeAttributes-colAction-id"
                   />
                 </colgroup>
-                <thead
-                  class="MuiTableHead-root-id"
-                >
-                  <tr
-                    class="MuiTableRow-root-id MuiTableRow-head-id"
-                  >
-                    <th
-                      class="MuiTableCell-root-id MuiTableCell-head-id ProductTypeAttributes-colName-id"
-                      scope="col"
-                    >
-                      Attribute name
-                    </th>
-                    <th
-                      class="MuiTableCell-root-id MuiTableCell-head-id ProductTypeAttributes-colName-id"
-                      scope="col"
-                    >
-                      Slug
-                    </th>
-                    <th
-                      class="MuiTableCell-root-id MuiTableCell-head-id"
-                      scope="col"
-                    />
-                  </tr>
-                </thead>
                 <tbody
                   class="MuiTableBody-root-id"
                 >