djkato/saleor-dashboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Metadata by default no expanded (#3172)

Browse source
This commit is contained in:
Timur Carpeev 2023-02-21 16:14:00 +01:00 committed by GitHub
parent 82071f4b88
commit 6434f277e8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cypress/elements/shared/button-selectors.js
View file

@ -19,4 +19,5 @@ export const BUTTON_SELECTORS = {
deleteSelectedElementsButton:
'[data-test-id = "delete-selected-elements-icon"]',
dialogBackButton: '[data-test-id="back"]',
expandMetadataButton: '[data-test-id="expand"]',
};

2
cypress/support/pages/catalog/products/productDetailsPage.js
View file

@ -73,9 +73,11 @@ export function fillUpAllCommonFieldsInCreateAndUpdate({
editSeoSettings(seo);
})
.then(() => {
cy.get(BUTTON_SELECTORS.expandMetadataButton).first().click();
addMetadataField(metadata.public);
})
.then(() => {
cy.get(BUTTON_SELECTORS.expandMetadataButton).last().click();
addMetadataField(metadata.private);
});
}

14
src/components/Metadata/MetadataCard.tsx
View file

@ -15,7 +15,7 @@ import {
} from "@material-ui/core";
import { DeleteIcon, ExpandIcon, IconButton } from "@saleor/macaw-ui";
import clsx from "clsx";
import React, { useEffect } from "react";
import React from "react";
import { FormattedMessage, useIntl } from "react-intl";
import CardTitle from "../CardTitle";
@ -39,19 +39,9 @@ const MetadataCard: React.FC<MetadataCardProps> = ({
onChange,
}) => {
const intl = useIntl();
const loaded = React.useRef(false);
const [expanded, setExpanded] = React.useState(true);
const [expanded, setExpanded] = React.useState(false);
const classes = useStyles();
useEffect(() => {
if (data !== undefined) {
loaded.current = true;
if (data.length > 0) {
setExpanded(false);
}
}
}, [data === undefined]);
return (
<Card
data-test-id="metadata-editor"