From 44eb27fed3783636263d1949675f0731ea489c21 Mon Sep 17 00:00:00 2001
From: Lukasz Ostrowski <lukasz.ostrowski@saleor.io>
Date: Mon, 10 Oct 2022 13:22:16 +0200
Subject: [PATCH] Hide app privacy URL if not provided (#2357)

---
 package-lock.json                             | 10 ++++----
 .../AppInstallPage/AppInstallPage.tsx         | 24 ++++++++++---------
 .../__snapshots__/Stories.test.ts.snap        |  6 -----
 3 files changed, 18 insertions(+), 22 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index c8cc82f12..dc9c23926 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -10129,7 +10129,7 @@
     "buffer-crc32": {
       "version": "0.2.13",
       "resolved": "https://registry.npmjs.org/buffer-crc32/-/buffer-crc32-0.2.13.tgz",
-      "integrity": "sha1-DTM+PwDqxQqhRUq9MO+MKl2ackI=",
+      "integrity": "sha512-VO9Ht/+p3SN7SKWqcrgEzjGbRSJYTx+Q1pTQC0wrWqHx0vpJraQ6GtHx8tvcg1rlK1byhU5gccxgOgj7B0TDkQ==",
       "dev": true
     },
     "buffer-equal-constant-time": {
@@ -14940,7 +14940,7 @@
         "pify": {
           "version": "2.3.0",
           "resolved": "https://registry.npmjs.org/pify/-/pify-2.3.0.tgz",
-          "integrity": "sha1-7RQaasBDqEnqWISY59yosVMw6Qw=",
+          "integrity": "sha512-udgsAY+fTnvv7kI7aaxbqwWNb0AHiB0qBO89PZKPkoTmGOgdbrHDKD+0B2X4uTfJ/FT1R09r9gTsjUjNJotuog==",
           "dev": true
         }
       }
@@ -15421,7 +15421,7 @@
     "fd-slicer": {
       "version": "1.1.0",
       "resolved": "https://registry.npmjs.org/fd-slicer/-/fd-slicer-1.1.0.tgz",
-      "integrity": "sha1-JcfInLH5B3+IkbvmHY85Dq4lbx4=",
+      "integrity": "sha512-cE1qsB/VwyQozZ+q1dGxR8LBYNZeofhEdUNGSMbQD3Gw2lAzX9Zb3uIU6Ebc/Fmyjo9AWWfnn0AUCHqtevs/8g==",
       "dev": true,
       "requires": {
         "pend": "~1.2.0"
@@ -23572,7 +23572,7 @@
     "ospath": {
       "version": "1.2.2",
       "resolved": "https://registry.npmjs.org/ospath/-/ospath-1.2.2.tgz",
-      "integrity": "sha1-EnZjl3Sj+O8lcvf+QoDg6kVQwHs=",
+      "integrity": "sha512-o6E5qJV5zkAbIDNhGSIlyOhScKXgQrSRMilfph0clDfM0nEnBOlKlH4sWDmG95BW/CvwNz0vmm7dJVtU2KlMiA==",
       "dev": true
     },
     "p-cancelable": {
@@ -24125,7 +24125,7 @@
     "pend": {
       "version": "1.2.0",
       "resolved": "https://registry.npmjs.org/pend/-/pend-1.2.0.tgz",
-      "integrity": "sha1-elfrVQpng/kRUzH89GY9XI4AelA=",
+      "integrity": "sha512-F3asv42UuXchdzt+xXqfW1OGlVBe+mxa2mqI0pg5yAHZPvFmY3Y6drSf/GQ1A86WgWEN9Kzh/WrgKa6iGcHXLg==",
       "dev": true
     },
     "performance-now": {
diff --git a/src/apps/components/AppInstallPage/AppInstallPage.tsx b/src/apps/components/AppInstallPage/AppInstallPage.tsx
index 6c30ba76b..9bbcdacce 100644
--- a/src/apps/components/AppInstallPage/AppInstallPage.tsx
+++ b/src/apps/components/AppInstallPage/AppInstallPage.tsx
@@ -115,17 +115,19 @@ export const AppInstallPage: React.FC<AppInstallPageProps> = ({
                   description="install app privacy"
                   values={{ name }}
                 />
-                <a
-                  href={data?.dataPrivacyUrl}
-                  rel="noopener noreferrer"
-                  target="_blank"
-                >
-                  <FormattedMessage
-                    id="k5lHFp"
-                    defaultMessage="Learn more about data privacy"
-                    description="app data privacy link"
-                  />
-                </a>
+                {!!data?.dataPrivacyUrl && (
+                  <a
+                    href={data?.dataPrivacyUrl}
+                    rel="noopener noreferrer"
+                    target="_blank"
+                  >
+                    <FormattedMessage
+                      id="k5lHFp"
+                      defaultMessage="Learn more about data privacy"
+                      description="app data privacy link"
+                    />
+                  </a>
+                )}
               </Typography>
             </>
           )}
diff --git a/src/storybook/__snapshots__/Stories.test.ts.snap b/src/storybook/__snapshots__/Stories.test.ts.snap
index 9ac6082b7..c84df2310 100644
--- a/src/storybook/__snapshots__/Stories.test.ts.snap
+++ b/src/storybook/__snapshots__/Stories.test.ts.snap
@@ -26312,12 +26312,6 @@ exports[`Storyshots Views / Apps / Install App default 1`] = `
           class="MuiTypography-root-id AppList-installPrivacyText-id MuiTypography-body2-id"
         >
           Uninstalling the app will remove all your customer’s personal data stored by app. 
-          <a
-            rel="noopener noreferrer"
-            target="_blank"
-          >
-            Learn more about data privacy
-          </a>
         </div>
       </div>
     </div>