djkato/saleor-dashboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix state triggering for filters (#3973)

Browse source
This commit is contained in:
Patryk Andrzejewski 2023-07-21 15:19:15 +02:00 committed by GitHub
parent 5a6c255004
commit 423d7cdc8b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/components/ConditionalFilter/ValueProvider/useUrlValueProvider.ts
View file

@ -41,8 +41,10 @@ export const useUrlValueProvider = (
}, []); }, []);
useEffect(() => { useEffect(() => {
if (loading) return
setValue(tokenizedUrl.asFilterValuesFromResponse(data)); setValue(tokenizedUrl.asFilterValuesFromResponse(data));
}, [data]); }, [data, loading]);
const persist = (filterValue: FilterContainer) => { const persist = (filterValue: FilterContainer) => {
router.history.replace({ router.history.replace({

2
src/components/ConditionalFilter/useContainerState.ts
View file

@ -56,7 +56,7 @@ export const useContainerState = (valueProvider: FilterValueProvider) => {
if (!valueProvider.loading) { if (!valueProvider.loading) {
setValue(valueProvider.value); setValue(valueProvider.value);
} }
}, [valueProvider.loading]); }, [valueProvider.loading, valueProvider.value]);
const isFilterElementAtIndex = ( const isFilterElementAtIndex = (
elIndex: number, elIndex: number,