From 26f8a776be394b3101699cf9f108abc6b65236a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Dro=C5=84?= <dron.official@yahoo.com>
Date: Wed, 30 Mar 2022 15:50:47 +0200
Subject: [PATCH] Fix variant create null thumbnail (#1956)

* Fix null thumbnail error

* Fix too few hooks rendered on non-existent products & variants
---
 .../components/ProductVariantPage/ProductVariantPage.tsx  | 2 +-
 src/products/views/ProductUpdate/ProductUpdate.tsx        | 7 ++++---
 src/products/views/ProductVariant.tsx                     | 8 ++++----
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/products/components/ProductVariantPage/ProductVariantPage.tsx b/src/products/components/ProductVariantPage/ProductVariantPage.tsx
index 29426bab7..37de14fb9 100644
--- a/src/products/components/ProductVariantPage/ProductVariantPage.tsx
+++ b/src/products/components/ProductVariantPage/ProductVariantPage.tsx
@@ -235,7 +235,7 @@ const ProductVariantPage: React.FC<ProductVariantPageProps> = ({
                     <ProductVariantNavigation
                       current={variant?.id}
                       defaultVariantId={defaultVariantId}
-                      fallbackThumbnail={variant?.product?.thumbnail.url}
+                      fallbackThumbnail={variant?.product?.thumbnail?.url}
                       variants={variant?.product.variants}
                       onAdd={onAdd}
                       onRowClick={(variantId: string) => {
diff --git a/src/products/views/ProductUpdate/ProductUpdate.tsx b/src/products/views/ProductUpdate/ProductUpdate.tsx
index 06388481b..a61e69d15 100644
--- a/src/products/views/ProductUpdate/ProductUpdate.tsx
+++ b/src/products/views/ProductUpdate/ProductUpdate.tsx
@@ -389,9 +389,6 @@ export const ProductUpdate: React.FC<ProductUpdateProps> = ({ id, params }) => {
 
   const handleBack = () => navigate(productListUrl());
 
-  if (product === null) {
-    return <NotFoundPage onBack={handleBack} />;
-  }
   const handleVariantAdd = () => navigate(productVariantAddUrl(id));
   const handleVariantsAdd = () => navigate(productVariantCreatorUrl(id));
 
@@ -520,6 +517,10 @@ export const ProductUpdate: React.FC<ProductUpdateProps> = ({ id, params }) => {
     onFetchMore: loadMoreAttributeValues
   };
 
+  if (product === null) {
+    return <NotFoundPage onBack={handleBack} />;
+  }
+
   return (
     <>
       <WindowTitle title={data?.product?.name} />
diff --git a/src/products/views/ProductVariant.tsx b/src/products/views/ProductVariant.tsx
index 832910f88..3dbfcefdb 100644
--- a/src/products/views/ProductVariant.tsx
+++ b/src/products/views/ProductVariant.tsx
@@ -197,10 +197,6 @@ export const ProductVariant: React.FC<ProductUpdateProps> = ({
   const variant = data?.productVariant;
   const channels = createVariantChannels(variant);
 
-  if (variant === null) {
-    return <NotFoundPage onBack={handleBack} />;
-  }
-
   const [
     deactivatePreorder,
     deactivatePreoderOpts
@@ -360,6 +356,10 @@ export const ProductVariant: React.FC<ProductUpdateProps> = ({
   const attributeValues =
     mapEdgesToItems(searchAttributeValuesOpts?.data?.attribute.choices) || [];
 
+  if (variant === null) {
+    return <NotFoundPage onBack={handleBack} />;
+  }
+
   return (
     <>
       <WindowTitle title={data?.productVariant?.name} />