Fix no-case-declarations eslint rule (#4098)

.changeset/tasty-turtles-cover.md

@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+Fix eslint rule no-case-declarations

.eslintrc.json

@@ -100,8 +100,7 @@
     "react-refresh/only-export-components": "off",
     "array-callback-return": "off",
     "import/export": "off",
-    "n/no-callback-literal": "off",
+    "n/no-callback-literal": "warn"
-    "no-case-declarations": "warn"
   },
   "ignorePatterns": ["node_modules/", "**/types/**/*", "type-policies.ts"]
 }

src/categories/components/CategoryProductListDatagrid/datagrid.ts

@@ -35,10 +35,13 @@ export const createGetCellContent =
 
     switch (columnId) {
       case "name":
-        const name = rowData?.name ?? "";
+        return thumbnailCell(
-        return thumbnailCell(name, rowData?.thumbnail?.url ?? "", {
+          rowData?.name ?? "",
-          cursor: "pointer",
+          rowData?.thumbnail?.url ?? "",
-        });
+          {
+            cursor: "pointer",
+          },
+        );
       default:
         return readonlyTextCell("", false);
     }

src/collections/components/CollectionListDatagrid/datagrid.ts

@@ -81,7 +81,7 @@ export const createGetCellContent =
         return readonlyTextCell(
           rowData?.products?.totalCount?.toString() ?? "",
         );
-      case "availability":
+      case "availability": {
         const { label, color } = !!channel
           ? getAvailablilityLabelWhenSelectedChannel(
               channel,
@@ -104,6 +104,7 @@ export const createGetCellContent =
             allowOverlay: false,
           },
         );
+      }
       default:
         return readonlyTextCell("");
     }

src/components/Attributes/AttributeRow.tsx

@@ -147,7 +147,7 @@ const AttributeRow: React.FC<AttributeRowProps> = ({
           />
         </BasicAttributeRow>
       );
-    case AttributeInputTypeEnum.RICH_TEXT:
+    case AttributeInputTypeEnum.RICH_TEXT: {
       const {
         getShouldMount,
         getDefaultValue,
@@ -178,6 +178,7 @@ const AttributeRow: React.FC<AttributeRowProps> = ({
           )}
         </BasicAttributeRow>
       );
+    }
     case AttributeInputTypeEnum.NUMERIC:
       return (
         <BasicAttributeRow

src/giftCards/GiftCardsList/GiftCardsListDatagrid/datagrid.ts

@@ -89,7 +89,7 @@ export const createGetCellContent =
             last4CodeChars: rowData?.last4CodeChars ?? "",
           }),
         );
-      case "status":
+      case "status": {
         const status = getStatusText(rowData);
 
         if (!status) {
@@ -121,6 +121,7 @@ export const createGetCellContent =
           ],
           [statusLabel],
         );
+      }
       case "tag":
         return readonlyTextCell(getTagCellText(rowData?.tags ?? []));
       case "product":

src/orders/components/OrderDraftDetailsDatagrid/datagrid.ts

@@ -130,7 +130,7 @@ export const useGetCellContent = ({
             allowOverlay: true,
           },
         );
-      case "status":
+      case "status": {
         const orderErrors = getOrderErrors(errors, rowData.id);
         const status = getOrderLineStatus(intl, rowData, orderErrors);
 
@@ -142,6 +142,7 @@ export const useGetCellContent = ({
             allowOverlay: false,
           },
         );
+      }
       case "sku":
         return readonlyTextCell(rowData?.productSku ?? "", false);
       case "variantName":

src/orders/components/OrderTransaction/components/TransactionEvents/components/EventStatus.tsx

@@ -53,8 +53,9 @@ export const EventStatus: React.FC<EventStatusProps> = ({ status }) => {
           label={intl.formatMessage(statusMessages.info)}
         />
       );
-    default:
+    default: {
       const _exhaustiveCheck: never = status;
       return _exhaustiveCheck;
+    }
   }
 };

src/pages/components/PageListDatagrid/datagrid.ts

@@ -64,7 +64,7 @@ export const createGetCellContent =
         return readonlyTextCell(rowData?.title ?? "");
       case "slug":
         return readonlyTextCell(rowData?.slug ?? "");
-      case "visible":
+      case "visible": {
         const tag = rowData?.isPublished
           ? intl.formatMessage(messages.published)
           : intl.formatMessage(messages.notPublished);
@@ -82,6 +82,7 @@ export const createGetCellContent =
           ],
           [tag],
         );
+      }
       default:
         return readonlyTextCell("");
     }

src/products/components/ProductVariants/utils.tsx

@@ -122,9 +122,10 @@ export function getData({
 
   switch (columnId) {
     case "name":
-    case "sku":
+    case "sku": {
       const value = change ?? (dataRow ? dataRow[columnId] : "");
       return textCell(value || "");
+    }
   }
 
   if (getColumnStock(columnId)) {

src/products/views/ProductList/filters.ts

@@ -331,7 +331,7 @@ export const parseFilterValue = (
           lte: isMulti ? value[1] || null : value[0],
         }),
       };
-    case ProductListUrlFiltersAsDictWithMultipleValues.numericAttributes:
+    case ProductListUrlFiltersAsDictWithMultipleValues.numericAttributes: {
       const [gte, lte] = value.map(v => parseFloat(v));
 
       return {
@@ -341,6 +341,7 @@ export const parseFilterValue = (
           lte: isMulti ? lte || undefined : gte || undefined,
         },
       };
+    }
     default:
       return { ...name, values: value };
   }

src/staff/components/StaffListDatagrid/datagrid.ts

@@ -73,7 +73,7 @@ export const createGetCellContent =
             cursor: "pointer",
           },
         );
-      case "status":
+      case "status": {
         const isActive = rowData?.isActive;
         const status = isActive
           ? intl.formatMessage(commonStatusMessages.active)
@@ -96,6 +96,7 @@ export const createGetCellContent =
             allowOverlay: false,
           },
         );
+      }
       case "email":
         return readonlyTextCell(rowData?.email ?? PLACEHOLDER);
       default: