Fix test selectors

This commit is contained in:
dominik-zeglen 2020-09-09 13:15:18 +02:00
parent 297fa35edd
commit 14b32db8ec
5 changed files with 9 additions and 7 deletions

View file

@ -1,4 +1,4 @@
/* eslint-disable sort-keys */ /* eslint-disable sort-keys */
export const LEFT_MENU_SELECTORS = { export const LEFT_MENU_SELECTORS = {
catalog: "[data-testid='catalogue']" catalog: "[data-test-id='catalogue']"
}; };

View file

@ -7,7 +7,7 @@ describe("Warehouse settings", () => {
xit("Warehouse section visible in the configuration", () => { xit("Warehouse section visible in the configuration", () => {
cy.visit("/configuration/") cy.visit("/configuration/")
.loginUser() .loginUser()
.get("[data-testid=warehouses][data-test=settingsSubsection]") .get("[data-test-id=warehouses][data-test=settingsSubsection]")
.click(); .click();
cy.location("pathname").should("eq", "/warehouses/"); cy.location("pathname").should("eq", "/warehouses/");
}); });

View file

@ -146,7 +146,11 @@ const MenuItem: React.FC<MenuItemProps> = ({
ref={anchor} ref={anchor}
onClick={event => handleClick(event, menuItem)} onClick={event => handleClick(event, menuItem)}
> >
<button className={classes.menuItemBtn}> <button
className={classes.menuItemBtn}
data-test="menu-item-label"
data-test-id={menuItem.testingContextId}
>
{menuItem.icon && <SVG className={classes.icon} src={menuItem.icon} />} {menuItem.icon && <SVG className={classes.icon} src={menuItem.icon} />}
<Typography <Typography
aria-label={menuItem.ariaLabel} aria-label={menuItem.ariaLabel}
@ -154,8 +158,6 @@ const MenuItem: React.FC<MenuItemProps> = ({
[classes.hideLabel]: isMenuShrunk [classes.hideLabel]: isMenuShrunk
})} })}
variant="body2" variant="body2"
data-test="menu-item-label"
data-test-id={menuItem.testingContextId}
> >
{menuItem.label} {menuItem.label}
</Typography> </Typography>

View file

@ -127,7 +127,7 @@ export const ConfigurationPage: React.FC<ConfigurationPageProps> = props => {
onClick={() => onSectionClick(item.url)} onClick={() => onSectionClick(item.url)}
key={itemIndex} key={itemIndex}
data-test="settingsSubsection" data-test="settingsSubsection"
data-testid={item.title.toLowerCase()} data-test-id={item.title.toLowerCase()}
> >
<CardContent className={classes.cardContent}> <CardContent className={classes.cardContent}>
<div className={classes.icon}>{item.icon}</div> <div className={classes.icon}>{item.icon}</div>

View file

@ -131,7 +131,7 @@ const WarehouseList: React.FC<WarehouseListProps> = props => {
onClick={warehouse ? onRowClick(warehouse.id) : undefined} onClick={warehouse ? onRowClick(warehouse.id) : undefined}
key={warehouse ? warehouse.id : "skeleton"} key={warehouse ? warehouse.id : "skeleton"}
data-test="warehouseEntry" data-test="warehouseEntry"
data-testid={warehouse?.name.toLowerCase().replace(" ", "")} data-test-id={warehouse?.name.toLowerCase().replace(" ", "")}
> >
<TableCell className={classes.colName} data-test="name"> <TableCell className={classes.colName} data-test="name">
{maybe<React.ReactNode>(() => warehouse.name, <Skeleton />)} {maybe<React.ReactNode>(() => warehouse.name, <Skeleton />)}