Create GH workflow for UI review assignment (#1046)
* test * Simplify workflow * Unassign when checkbox is unchecked
This commit is contained in:
parent
588175df30
commit
078628f99f
2 changed files with 23 additions and 10 deletions
15
.github/PULL_REQUEST_TEMPLATE.md
vendored
15
.github/PULL_REQUEST_TEMPLATE.md
vendored
|
@ -13,16 +13,11 @@ greatly reduce the amount of work needed to review your work. -->
|
|||
|
||||
<!-- Please keep this section. It will make maintainer's life easier. -->
|
||||
|
||||
1. [ ] All visible strings are translated with proper context.
|
||||
1. [ ] All data-formatting is locale-aware (dates, numbers, and so on).
|
||||
1. [ ] Translated strings are extracted.
|
||||
1. [ ] Number of API calls is optimized.
|
||||
1. [ ] The changes are tested.
|
||||
1. [ ] Data-test are added for new elements.
|
||||
1. [ ] Type definitions are up to date.
|
||||
1. [ ] Changes are mentioned in the changelog.
|
||||
1. [ ] The changes are tested in different browsers (Chrome, Firefox, Safari).
|
||||
1. [ ] The changes are tested in light and dark mode.
|
||||
1. [ ] This code contains UI changes
|
||||
2. [ ] All visible strings are translated with proper context including data-formatting
|
||||
3. [ ] Attributes `[data-test-id]` are added for new elements
|
||||
4. [ ] Changes are mentioned in the changelog
|
||||
5. [ ] The changes are tested in different browsers and in light/dark mode
|
||||
|
||||
### Test environment config
|
||||
|
||||
|
|
18
.github/workflows/review-assignment.yml
vendored
Normal file
18
.github/workflows/review-assignment.yml
vendored
Normal file
|
@ -0,0 +1,18 @@
|
|||
name: Review assignment
|
||||
|
||||
on:
|
||||
pull_request:
|
||||
types: [opened, edited]
|
||||
|
||||
jobs:
|
||||
assign_ui:
|
||||
runs-on: ubuntu-latest
|
||||
name: Assign UI Reviewer
|
||||
if: contains(github.event.pull_request.body , 'This code contains UI changes')
|
||||
steps:
|
||||
- name: Add/Remove UI reviewer
|
||||
uses: jwm0/add-reviewer-gh-action@1.0.4
|
||||
with:
|
||||
reviewers: "pwgryglak"
|
||||
token: ${{ secrets.GITHUB_TOKEN }}
|
||||
remove: ${{ !contains(github.event.pull_request.body , '[x] This code contains UI changes') }}
|
Loading…
Reference in a new issue