djkato/saleor-apps-redis_apl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix missing attribute values in products (#147)

Browse source 
* Fix missing attribute values in products
This commit is contained in:
Krzysztof Wolski 2023-02-13 17:08:20 +01:00 committed by GitHub
parent c1dab0ba18
commit ce17e45abe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 41 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/wet-dogs-warn.md Normal file
View file

@ -0,0 +1,5 @@
---
"saleor-app-search": patch
---
Fix missing attribute values in products

39
apps/search/src/lib/algolia/algoliaUtils.ts
View file

@ -1,4 +1,7 @@
import { ProductVariantWebhookPayloadFragment } from "../../../generated/graphql";
import {
ProductAttributesDataFragment,
ProductVariantWebhookPayloadFragment,
} from "../../../generated/graphql";
import { isNotNil } from "../isNotNil";
type PartialChannelListing = {
@ -55,6 +58,22 @@ export function formatMetadata({ product }: ProductVariantWebhookPayloadFragment
export type AlgoliaObject = ReturnType<typeof productAndVariantToAlgolia>;
/**
* Returns object with a key being attribute name and value of all attribute values
* separated by comma. If no value is selected, an empty string will be used instead.
*/
const mapSelectedAttributesToRecord = (attr: ProductAttributesDataFragment) => {
if (!attr.attribute.name?.length) {
return undefined;
}
const filteredValues = attr.values.filter((v) => !!v.name?.length);
return {
[attr.attribute.name]: filteredValues.map((v) => v.name).join(", ") || "",
};
};
export function productAndVariantToAlgolia({
variant,
channel,
@ -65,10 +84,24 @@ export function productAndVariantToAlgolia({
const product = variant.product;
const attributes = {
...product.attributes.reduce((acc, attr, idx) => {
return { ...acc, [attr.attribute.name ?? ""]: attr.values[idx]?.name ?? "" };
const preparedAttr = mapSelectedAttributesToRecord(attr);
if (!preparedAttr) {
return acc;
}
return {
...acc,
...preparedAttr,
};
}, {}),
...variant.attributes.reduce((acc, attr, idx) => {
return { ...acc, [attr.attribute.name ?? ""]: attr.values[idx]?.name ?? "" };
const preparedAttr = mapSelectedAttributesToRecord(attr);
if (!preparedAttr) {
return acc;
}
return {
...acc,
...preparedAttr,
};
}, {}),
};