djkato/saleor-apps-redis_apl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: QA bugs in Taxes App (#654)

Browse source 
* fix: 🐛 turn off validateAddress in TaxJar

* refactor: ♻️ make avatax & taxjar schemas strict

* fix: 🐛 update providers bug

* build: 👷 add changeset

* Update cold-candles-fly.md
This commit is contained in:
Adrian Pilarczyk 2023-06-19 12:06:05 +02:00 committed by GitHub
parent c0d01db55d
commit c4be200925
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/cold-candles-fly.md Normal file
View file

@ -0,0 +1,5 @@
---
"saleor-app-taxes": patch
---
The update provider configuration views no longer return "invalid credentials" and "invalid address" errors in inappropriate cases. The latter required temporarily disabling the TaxJar address validation, as it currently doesn't work.

4
apps/taxes/src/modules/avatax/configuration/avatax-connection-repository.ts
View file

@ -13,7 +13,7 @@ import {
avataxConnectionSchema, avataxConnectionSchema,
} from "../avatax-connection-schema"; } from "../avatax-connection-schema";
const getSchema = avataxConnectionSchema; const getSchema = avataxConnectionSchema.strict();
export class AvataxConnectionRepository { export class AvataxConnectionRepository {
private crudSettingsManager: CrudSettingsManager; private crudSettingsManager: CrudSettingsManager;
@ -83,7 +83,7 @@ export class AvataxConnectionRepository {
return result.data; return result.data;
} }
async patch(id: string, input: AvataxConfig): Promise<void> { async patch(id: string, input: Pick<AvataxConnection, "config">): Promise<void> {
return this.crudSettingsManager.update(id, input); return this.crudSettingsManager.update(id, input);
} }

2
apps/taxes/src/modules/avatax/configuration/avatax-connection.service.ts
View file

@ -50,7 +50,7 @@ export class AvataxConnectionService {
await validationService.validate(input); await validationService.validate(input);
return this.avataxConnectionRepository.patch(id, input); return this.avataxConnectionRepository.patch(id, { config: input });
} }
async delete(id: string): Promise<void> { async delete(id: string): Promise<void> {

4
apps/taxes/src/modules/taxjar/configuration/taxjar-connection-repository.ts
View file

@ -9,7 +9,7 @@ import {
import { TAX_PROVIDER_KEY } from "../../provider-connections/public-provider-connections.service"; import { TAX_PROVIDER_KEY } from "../../provider-connections/public-provider-connections.service";
import { TaxJarConfig, TaxJarConnection, taxJarConnection } from "../taxjar-connection-schema"; import { TaxJarConfig, TaxJarConnection, taxJarConnection } from "../taxjar-connection-schema";
const getSchema = taxJarConnection; const getSchema = taxJarConnection.strict();
export class TaxJarConnectionRepository { export class TaxJarConnectionRepository {
private crudSettingsManager: CrudSettingsManager; private crudSettingsManager: CrudSettingsManager;
@ -79,7 +79,7 @@ export class TaxJarConnectionRepository {
return result.data; return result.data;
} }
async patch(id: string, input: TaxJarConfig): Promise<void> { async patch(id: string, input: Pick<TaxJarConnection, "config">): Promise<void> {
return this.crudSettingsManager.update(id, input); return this.crudSettingsManager.update(id, input);
} }

2
apps/taxes/src/modules/taxjar/configuration/taxjar-connection.service.ts
View file

@ -49,7 +49,7 @@ export class TaxJarConnectionService {
await validationService.validate(input); await validationService.validate(input);
return this.taxJarConnectionRepository.patch(id, input); return this.taxJarConnectionRepository.patch(id, { config: input });
} }
async delete(id: string): Promise<void> { async delete(id: string): Promise<void> {

7
apps/taxes/src/modules/taxjar/taxjar-client.ts
View file

@ -46,7 +46,12 @@ export class TaxJarClient {
return this.client.createOrder(params); return this.client.createOrder(params);
} }
/**
* TaxJar validateAddress doesn't work. It's turned off for now.
* @see https://github.com/taxjar/taxjar-node/issues/70
* @todo Revisit this when TaxJar fixes the issue. Alternatively, create a custom validation.
*/
async validateAddress({ params }: ValidateAddressArgs) { async validateAddress({ params }: ValidateAddressArgs) {
return this.client.validateAddress(params); // return this.client.validateAddress(params);
} }
} }