djkato/saleor-apps-redis_apl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Protect logger from trace and debug in production (#527)

Browse source 
* Protec logger from trace and debug in production

* Better error message
This commit is contained in:
Lukasz Ostrowski 2023-06-01 16:33:25 +02:00 committed by GitHub
parent 6a9da7ac38
commit b75a66497b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/wet-points-deny.md Normal file
View file

@ -0,0 +1,5 @@
---
"@saleor/apps-shared": minor
---
Disabled possibility to create logger if level is DEBUG or TRACE and NODE_ENV is production. This is an additional protection for logging sensitive data.

13
packages/shared/src/logger.ts
View file

@ -1,10 +1,21 @@
import pino from "pino";
const forbiddenProductionLevels = ["debug", "trace"];
const logLevel = process.env.APP_LOG_LEVEL ?? "silent";
if (process.env.NODE_ENV === "production" && forbiddenProductionLevels.includes(logLevel)) {
throw new Error(
`Production app can only log INFO or higher log level. "${logLevel}" is development only.`
);
process.exit(1);
}
/**
* TODO Set up log drain etc
*/
export const logger = pino({
level: process.env.APP_LOG_LEVEL ?? "silent",
level: logLevel,
redact: ["token", "apiKey"],
transport:
process.env.NODE_ENV === "development"