refactor: ♻️ normalize avatax errors

apps/taxes/src/modules/avatax/avatax-error-normalizer.ts

@@ -0,0 +1,17 @@
+import { createLogger } from "../../lib/logger";
+import { AvalaraError } from "avatax/lib/AvaTaxClient";
+import { TaxExternalError, TaxUnexpectedError } from "../taxes/tax-error";
+
+export class AvataxErrorNormalizer {
+  private logger = createLogger({ name: "AvataxErrorNormalizer" });
+
+  normalize(error: unknown) {
+    if (error instanceof AvalaraError) {
+      this.logger.debug(error.stack, "AvalaraError occurred");
+
+      return new TaxExternalError(error.message);
+    }
+
+    return TaxUnexpectedError.normalize(error);
+  }
+}

apps/taxes/src/modules/avatax/calculate-taxes/avatax-calculate-taxes-adapter.ts

@@ -8,6 +8,7 @@ import { AvataxConfig } from "../avatax-connection-schema";
 import { ClientLogger } from "../../logs/client-logger";
 import { AvataxCalculateTaxesPayloadService } from "./avatax-calculate-taxes-payload.service";
 import { AvataxCalculateTaxesResponseTransformer } from "./avatax-calculate-taxes-response-transformer";
+import { AvataxErrorNormalizer } from "../avatax-error-normalizer";
 
 export const SHIPPING_ITEM_CODE = "Shipping";
 
@@ -67,6 +68,8 @@ export class AvataxCalculateTaxesAdapter
 
       return transformedResponse;
     } catch (error) {
+      const errorNormalizer = new AvataxErrorNormalizer();
+
       this.clientLogger.push({
         event: "[CalculateTaxes] createTransaction",
         status: "error",
@@ -75,7 +78,7 @@ export class AvataxCalculateTaxesAdapter
           output: error,
         },
       });
-      throw error;
+      throw errorNormalizer.normalize(error);
     }
   }
 }

apps/taxes/src/modules/avatax/order-cancelled/avatax-order-cancelled-adapter.ts

@@ -5,6 +5,7 @@ import { AvataxClient, VoidTransactionArgs } from "../avatax-client";
 import { AvataxConfig } from "../avatax-connection-schema";
 import { ClientLogger } from "../../logs/client-logger";
 import { AvataxOrderCancelledPayloadTransformer } from "./avatax-order-cancelled-payload-transformer";
+import { AvataxErrorNormalizer } from "../avatax-error-normalizer";
 
 export type AvataxOrderCancelledTarget = VoidTransactionArgs;
 
@@ -43,6 +44,8 @@ export class AvataxOrderCancelledAdapter implements WebhookAdapter<OrderCancelle
 
       this.logger.debug(`Successfully voided the transaction of id: ${target.transactionCode}`);
     } catch (error) {
+      const errorNormalizer = new AvataxErrorNormalizer();
+
       this.clientLogger.push({
         event: "[OrderCancelled] voidTransaction",
         status: "error",
@@ -51,6 +54,8 @@ export class AvataxOrderCancelledAdapter implements WebhookAdapter<OrderCancelle
           output: error,
         },
       });
+
+      throw errorNormalizer.normalize(error);
     }
   }
 }

apps/taxes/src/modules/avatax/order-confirmed/avatax-order-confirmed-adapter.ts

@@ -1,13 +1,14 @@
 import { AuthData } from "@saleor/app-sdk/APL";
 import { OrderConfirmedSubscriptionFragment } from "../../../../generated/graphql";
 import { Logger, createLogger } from "../../../lib/logger";
+import { ClientLogger } from "../../logs/client-logger";
 import { CreateOrderResponse } from "../../taxes/tax-provider-webhook";
 import { WebhookAdapter } from "../../taxes/tax-webhook-adapter";
 import { AvataxClient } from "../avatax-client";
 import { AvataxConfig } from "../avatax-connection-schema";
-import { ClientLogger } from "../../logs/client-logger";
 import { AvataxOrderConfirmedPayloadService } from "./avatax-order-confirmed-payload.service";
 import { AvataxOrderConfirmedResponseTransformer } from "./avatax-order-confirmed-response-transformer";
+import { AvataxErrorNormalizer } from "../avatax-error-normalizer";
 
 type AvataxOrderConfirmedPayload = {
   order: OrderConfirmedSubscriptionFragment;
@@ -68,6 +69,8 @@ export class AvataxOrderConfirmedAdapter
 
       return transformedResponse;
     } catch (error) {
+      const errorNormalizer = new AvataxErrorNormalizer();
+
       this.clientLogger.push({
         event: "[OrderConfirmed] createTransaction",
         status: "error",
@@ -76,7 +79,8 @@ export class AvataxOrderConfirmedAdapter
           output: error,
         },
       });
-      throw error;
+
+      throw errorNormalizer.normalize(error);
     }
   }
 }