From 1c04327bd67cefc85228943a778864dfc61cb514 Mon Sep 17 00:00:00 2001 From: Adrian Pilarczyk Date: Tue, 7 Mar 2023 12:07:11 +0100 Subject: [PATCH] fix: :bug: address pr feedback --- .../modules/taxes/providers/taxjar/taxjar-calculate.ts | 1 + .../src/pages/api/webhooks/checkout-calculate-taxes.ts | 8 -------- .../taxes/src/pages/api/webhooks/order-calculate-taxes.ts | 8 -------- 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/apps/taxes/src/modules/taxes/providers/taxjar/taxjar-calculate.ts b/apps/taxes/src/modules/taxes/providers/taxjar/taxjar-calculate.ts index 9a31587..9be401a 100644 --- a/apps/taxes/src/modules/taxes/providers/taxjar/taxjar-calculate.ts +++ b/apps/taxes/src/modules/taxes/providers/taxjar/taxjar-calculate.ts @@ -13,6 +13,7 @@ const formatCalculatedAmount = (amount: number) => { return Number(amount.toFixed(2)); }; +// * This type is related to `TaxLineItem` from TaxJar. It should be unified. type FetchTaxesLinePayload = { id: string; quantity: number; diff --git a/apps/taxes/src/pages/api/webhooks/checkout-calculate-taxes.ts b/apps/taxes/src/pages/api/webhooks/checkout-calculate-taxes.ts index 967c82f..db9ddc7 100644 --- a/apps/taxes/src/pages/api/webhooks/checkout-calculate-taxes.ts +++ b/apps/taxes/src/pages/api/webhooks/checkout-calculate-taxes.ts @@ -27,14 +27,6 @@ export default checkoutCalculateTaxesSyncWebhook.createHandler(async (req, res, const { authData, payload } = ctx; logger.info({ payload }, "Handler called with payload"); - if (!authData) { - logger.error("Auth data not found"); - logger.info("Returning no data"); - return res.send({}); - } - - logger.info("Parsing payload..."); - const validation = calculateTaxesPayloadSchema.safeParse(payload); if (!validation.success) { diff --git a/apps/taxes/src/pages/api/webhooks/order-calculate-taxes.ts b/apps/taxes/src/pages/api/webhooks/order-calculate-taxes.ts index f507f0e..c67d57f 100644 --- a/apps/taxes/src/pages/api/webhooks/order-calculate-taxes.ts +++ b/apps/taxes/src/pages/api/webhooks/order-calculate-taxes.ts @@ -27,14 +27,6 @@ export default orderCalculateTaxesSyncWebhook.createHandler(async (req, res, ctx const { authData, payload } = ctx; logger.info({ payload }, "Handler called with payload"); - if (!authData) { - logger.error("Auth data not found"); - logger.info("Returning no data"); - return res.status(200).json({}); - } - - logger.info("Parsing payload..."); - const validation = calculateTaxesPayloadSchema.safeParse(payload); if (!validation.success) {