feat: ✨ make companyCode optional (#458)
* feat: ✨ make companyCode optional * fix: 🐛 return empty string if no companyCode in order-fulfilled * build: 👷 add changeset
This commit is contained in:
parent
9ecb6291a5
commit
0c039f59dc
4 changed files with 16 additions and 9 deletions
5
.changeset/tasty-moose-obey.md
Normal file
5
.changeset/tasty-moose-obey.md
Normal file
|
@ -0,0 +1,5 @@
|
||||||
|
---
|
||||||
|
"saleor-app-taxes": minor
|
||||||
|
---
|
||||||
|
|
||||||
|
Make companyCode optional in Avatax.
|
|
@ -6,7 +6,7 @@ export const avataxConfigSchema = z.object({
|
||||||
username: z.string().min(1, { message: "Username requires at least one character." }),
|
username: z.string().min(1, { message: "Username requires at least one character." }),
|
||||||
password: z.string().min(1, { message: "Password requires at least one character." }),
|
password: z.string().min(1, { message: "Password requires at least one character." }),
|
||||||
isSandbox: z.boolean(),
|
isSandbox: z.boolean(),
|
||||||
companyCode: z.string().min(1, { message: "Company code requires at least one character." }),
|
companyCode: z.string().optional(),
|
||||||
isAutocommit: z.boolean(),
|
isAutocommit: z.boolean(),
|
||||||
shippingTaxCode: z.string().optional(),
|
shippingTaxCode: z.string().optional(),
|
||||||
});
|
});
|
||||||
|
|
|
@ -29,7 +29,7 @@ const mapPayload = ({ order, config }: CommitTransactionMapPayloadArgs): CommitT
|
||||||
|
|
||||||
return {
|
return {
|
||||||
transactionCode,
|
transactionCode,
|
||||||
companyCode: config.companyCode,
|
companyCode: config.companyCode ?? "",
|
||||||
documentType: DocumentType.SalesInvoice,
|
documentType: DocumentType.SalesInvoice,
|
||||||
model: {
|
model: {
|
||||||
commit: true,
|
commit: true,
|
||||||
|
|
|
@ -250,6 +250,7 @@ export const AvataxConfigurationForm = () => {
|
||||||
<TextField required label="Password" {...field} {...textFieldProps} />
|
<TextField required label="Password" {...field} {...textFieldProps} />
|
||||||
)}
|
)}
|
||||||
/>
|
/>
|
||||||
|
|
||||||
{formState.errors.password && (
|
{formState.errors.password && (
|
||||||
<FormHelperText error>{formState.errors.password.message}</FormHelperText>
|
<FormHelperText error>{formState.errors.password.message}</FormHelperText>
|
||||||
)}
|
)}
|
||||||
|
@ -260,15 +261,16 @@ export const AvataxConfigurationForm = () => {
|
||||||
control={control}
|
control={control}
|
||||||
defaultValue={defaultValues.companyCode}
|
defaultValue={defaultValues.companyCode}
|
||||||
render={({ field }) => (
|
render={({ field }) => (
|
||||||
<TextField
|
<TextField type="text" {...field} label="Company code" {...textFieldProps} />
|
||||||
required
|
|
||||||
type="text"
|
|
||||||
{...field}
|
|
||||||
label="Company code"
|
|
||||||
{...textFieldProps}
|
|
||||||
/>
|
|
||||||
)}
|
)}
|
||||||
/>
|
/>
|
||||||
|
<FormHelperText>
|
||||||
|
{"When not provided, the default company will be used. "}
|
||||||
|
<AppLink href="https://developer.avalara.com/erp-integration-guide/sales-tax-badge/transactions/simple-transactions/company-codes/">
|
||||||
|
Read more
|
||||||
|
</AppLink>{" "}
|
||||||
|
about company codes.
|
||||||
|
</FormHelperText>
|
||||||
{formState.errors.companyCode && (
|
{formState.errors.companyCode && (
|
||||||
<FormHelperText error>{formState.errors.companyCode.message}</FormHelperText>
|
<FormHelperText error>{formState.errors.companyCode.message}</FormHelperText>
|
||||||
)}
|
)}
|
||||||
|
|
Loading…
Reference in a new issue