From 915f6496f1a40e490f95ccca66b3136f66447169 Mon Sep 17 00:00:00 2001 From: Lukasz Ostrowski Date: Mon, 29 Aug 2022 09:01:16 +0200 Subject: [PATCH] Fix legacy createApp factory to not override targetDomain --- src/app-bridge/app-bridge.ts | 6 ++++++ src/app-bridge/index.ts | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/app-bridge/app-bridge.ts b/src/app-bridge/app-bridge.ts index da18d45..55d15ac 100644 --- a/src/app-bridge/app-bridge.ts +++ b/src/app-bridge/app-bridge.ts @@ -95,6 +95,12 @@ export class AppBridge { console.warn("document.referrer is empty"); } + if (!this.combinedOptions.targetDomain) { + console.error( + "No domain set, ensure ?domain param in iframe exist or provide in AppBridge constructor" + ); + } + this.setInitialState(); this.listenOnMessages(); } diff --git a/src/app-bridge/index.ts b/src/app-bridge/index.ts index 654bd60..29d16b9 100644 --- a/src/app-bridge/index.ts +++ b/src/app-bridge/index.ts @@ -9,5 +9,6 @@ export * from "./types"; /** * @deprecated use new AppBridge(), createApp will be removed */ -export const createApp = (targetDomain?: string) => new AppBridge({ targetDomain }); +export const createApp = (targetDomain?: string) => + new AppBridge(targetDomain ? { targetDomain } : undefined); export default createApp;