djkato/egui
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Place dark-light behind a feature gate in eframe and egui_glow (#1437)

Browse source
This commit is contained in:
Collin Kemper 2022-04-01 05:10:47 -04:00 committed by GitHub
parent 1d32670cf3
commit a52bbade45
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -17,6 +17,7 @@ NOTE: [`epaint`](epaint/CHANGELOG.md), [`eframe`](eframe/CHANGELOG.md), [`egui_w
* `ClippedMesh` has been replaced with `ClippedPrimitive` ([#1351](https://github.com/emilk/egui/pull/1351)). * `ClippedMesh` has been replaced with `ClippedPrimitive` ([#1351](https://github.com/emilk/egui/pull/1351)).
* Renamed `Frame::margin` to `Frame::inner_margin`. * Renamed `Frame::margin` to `Frame::inner_margin`.
* Renamed `AlphaImage` to `FontImage` to discourage any other use for it ([#1412](https://github.com/emilk/egui/pull/1412)). * Renamed `AlphaImage` to `FontImage` to discourage any other use for it ([#1412](https://github.com/emilk/egui/pull/1412)).
* `dark-light` (dark mode detection) is now an opt-in feature for `eframe` and `egui_glow` ([#1437](https://github.com/emilk/egui/pull/1437)).
### Fixed 🐛 ### Fixed 🐛
* Fixed ComboBoxes always being rendered left-aligned ([#1304](https://github.com/emilk/egui/pull/1304)). * Fixed ComboBoxes always being rendered left-aligned ([#1304](https://github.com/emilk/egui/pull/1304)).

2
eframe/Cargo.toml
View file

@ -42,6 +42,8 @@ screen_reader = [
"egui_web/screen_reader", "egui_web/screen_reader",
] ]
dark-light = [ "egui-winit/dark-light"] # detect dark mode system preference
[dependencies] [dependencies]
egui = { version = "0.17.0", path = "../egui", default-features = false } egui = { version = "0.17.0", path = "../egui", default-features = false }

3
egui_glow/Cargo.toml
View file

@ -53,6 +53,8 @@ screen_reader = ["egui-winit/screen_reader"]
# if you want to use glow painter on web disable this feature. # if you want to use glow painter on web disable this feature.
winit = ["egui-winit", "glutin"] winit = ["egui-winit", "glutin"]
dark-light = ["egui-winit/dark-light"] # detect dark mode system preference
[dependencies] [dependencies]
egui = { version = "0.17.0", path = "../egui", default-features = false, features = [ egui = { version = "0.17.0", path = "../egui", default-features = false, features = [
@ -67,7 +69,6 @@ tracing = "0.1"
[target.'cfg(not(target_arch = "wasm32"))'.dependencies] [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
egui-winit = { version = "0.17.0", path = "../egui-winit", optional = true, default-features = false, features = [ egui-winit = { version = "0.17.0", path = "../egui-winit", optional = true, default-features = false, features = [
"dark-light",
"epi_backend", "epi_backend",
] } ] }
glutin = { version = "0.28.0", optional = true } glutin = { version = "0.28.0", optional = true }