djkato/egui
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add dry run feature for anchor calculation. (#1) (#1856)

Browse source 
* Add dry run feature for anchor calculation. (#1)

This PR resolves issue: emilk#1852
We introduce dry_run flag which makes component invisible until we do second pass of rendering - which allows us to properly calculate position for anchor. (This removes rapid flicker when new window is drawn for the first time).

* Change naming convention and add description
This commit is contained in:
zapp88 2022-07-29 13:14:28 +02:00 committed by GitHub
parent 278db1c94b
commit 36a49ffba9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
egui/src/containers/area.rs
View file

@ -172,6 +172,12 @@ pub(crate) struct Prepared {
pub(crate) movable: bool, pub(crate) movable: bool,
enabled: bool, enabled: bool,
drag_bounds: Option<Rect>, drag_bounds: Option<Rect>,
/// Set the first frame of new windows with anchors.
///
/// This is so that we use the first frame to calculate the window size,
/// and then can correctly position the window the next frame,
/// without having one frame where the window is positioned in the wrong place.
temporarily_invisible: bool,
} }
impl Area { impl Area {
@ -214,11 +220,11 @@ impl Area {
}); });
state.pos = new_pos.unwrap_or(state.pos); state.pos = new_pos.unwrap_or(state.pos);
state.interactable = interactable; state.interactable = interactable;
let mut temporarily_invisible = false;
if let Some((anchor, offset)) = anchor { if let Some((anchor, offset)) = anchor {
if is_new { if is_new {
// unknown size temporarily_invisible = true;
ctx.request_repaint();
} else { } else {
let screen = ctx.available_rect(); let screen = ctx.available_rect();
state.pos = anchor.align_size_within_rect(state.size, screen).min + offset; state.pos = anchor.align_size_within_rect(state.size, screen).min + offset;
@ -233,6 +239,7 @@ impl Area {
movable, movable,
enabled, enabled,
drag_bounds, drag_bounds,
temporarily_invisible,
} }
} }
@ -314,7 +321,7 @@ impl Prepared {
clip_rect, clip_rect,
); );
ui.set_enabled(self.enabled); ui.set_enabled(self.enabled);
ui.set_visible(!self.temporarily_invisible);
ui ui
} }
@ -326,6 +333,7 @@ impl Prepared {
movable, movable,
enabled, enabled,
drag_bounds, drag_bounds,
temporarily_invisible: _,
} = self; } = self;
state.size = content_ui.min_rect().size(); state.size = content_ui.min_rect().size();