djkato/egui
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove warning about cpal drag and drop (#1329)

Browse source 
* Remove warning about cpal drag and drop

Given that the issue https://github.com/rust-windowing/winit/issues/1255 was closed by https://github.com/rust-windowing/winit/pull/1524, it would make sense to remove the warning about the issue from NativeOptions

* Change `NativeOptions::drag_and_drop_support` default to true
This commit is contained in:
Zachary Kohnen 2022-03-07 10:33:59 +01:00 committed by GitHub
parent d4bbea3967
commit 27e179268b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
eframe/CHANGELOG.md
View file

@ -5,6 +5,7 @@ NOTE: [`egui_web`](../egui_web/CHANGELOG.md), [`egui-winit`](../egui-winit/CHANG
## Unreleased
* Change default for `NativeOptions::drag_and_drop_support` to `true` ([#1329](https://github.com/emilk/egui/pull/1329))
## 0.17.0 - 2022-02-22

13
epi/src/lib.rs
View file

@ -221,10 +221,13 @@ pub struct NativeOptions {
/// If false it will be difficult to move and resize the app.
pub decorated: bool,
/// On Windows: enable drag and drop support.
/// Default is `false` to avoid issues with crates such as [`cpal`](https://github.com/RustAudio/cpal) which
/// will hang when combined with drag-and-drop.
/// See <https://github.com/rust-windowing/winit/issues/1255>.
/// On Windows: enable drag and drop support. Drag and drop can
/// not be disabled on other platforms.
///
/// See [winit's documentation][drag_and_drop] for information on why you
/// might want to disable this on windows.
///
/// [drag_and_drop]: https://docs.rs/winit/latest/x86_64-pc-windows-msvc/winit/platform/windows/trait.WindowBuilderExtWindows.html#tymethod.with_drag_and_drop
pub drag_and_drop_support: bool,
/// The application icon, e.g. in the Windows task bar etc.
@ -257,7 +260,7 @@ impl Default for NativeOptions {
always_on_top: false,
maximized: false,
decorated: true,
drag_and_drop_support: false,
drag_and_drop_support: true,
icon_data: None,
initial_window_pos: None,
initial_window_size: None,