Run clippy on all targets and all features (#347)

* Run clippy on all targets and all features

* check.sh: print each step

* impl ToString -related clippy fix
This commit is contained in:
Emil Ernerfeldt 2021-05-02 19:26:57 +02:00 committed by GitHub
parent 35c7b09285
commit 10b60d5361
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 2 deletions

View file

@ -119,7 +119,7 @@ jobs:
- uses: actions-rs/cargo@v1 - uses: actions-rs/cargo@v1
with: with:
command: clippy command: clippy
args: -- -D warnings args: --workspace --all-targets --all-features -- -D warnings -W clippy::all
doc: doc:
name: cargo doc name: cargo doc

View file

@ -1,5 +1,5 @@
#!/bin/bash #!/bin/bash
set -eu set -eux
# Checks all tests, lints etc. # Checks all tests, lints etc.
# Basically does what the CI does. # Basically does what the CI does.

View file

@ -340,6 +340,7 @@ pub mod http {
impl Request { impl Request {
/// Create a `GET` requests with the given url. /// Create a `GET` requests with the given url.
#[allow(clippy::needless_pass_by_value)]
pub fn get(url: impl ToString) -> Self { pub fn get(url: impl ToString) -> Self {
Self { Self {
method: "GET".to_owned(), method: "GET".to_owned(),
@ -349,6 +350,7 @@ pub mod http {
} }
/// Create a `POST` requests with the give url and body. /// Create a `POST` requests with the give url and body.
#[allow(clippy::needless_pass_by_value)]
pub fn post(url: impl ToString, body: impl ToString) -> Self { pub fn post(url: impl ToString, body: impl ToString) -> Self {
Self { Self {
method: "POST".to_owned(), method: "POST".to_owned(),